Skip to content

fix(tests): scope admin settings heading locator to the guests section #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ernolf merged 1 commit into from
Jul 30, 2026
Merged

fix(tests): scope admin settings heading locator to the guests section #1645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion playwright/e2e/admin-settings.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ test('Admin Guests settings page renders without errors', async ({ adminPage })

await adminPage.goto('/settings/admin/guests')

await expect(adminPage.getByRole('heading', { name: 'Guests', exact: true })).toBeVisible()
// Scope to our section: the framework also renders a hidden page <h1> with the section name.
await expect(adminPage.locator('#guest-settings').getByRole('heading', { name: 'Guests', exact: true })).toBeVisible()
await expect(adminPage.getByRole('checkbox', { name: /external storage/i })).toBeVisible()

expect(pageErrors, `uncaught page errors: ${pageErrors.join(' | ')}`).toEqual([])
Expand Down
Loading