perf(sharing): Avoid loading all shares from all users when unsharing#58057
Open
CarlSchwan wants to merge 2 commits intomasterfrom
Open
perf(sharing): Avoid loading all shares from all users when unsharing#58057CarlSchwan wants to merge 2 commits intomasterfrom
CarlSchwan wants to merge 2 commits intomasterfrom
Conversation
CarlSchwan
requested review from
ArtificialOwl,
icewind1991,
leftybournes and
salmart-dev
and removed request for
a team
CarlSchwan
force-pushed
the
carl/perf-delete-share
branch
2 times, most recently
from
d600563 to
a6b0c0a
Compare
First check which users have a shares and for which providers and then only load these shares. Avoid doing at most 5 SQL queries for each users a share was shared with if there are no shares. Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/perf-delete-share
branch
from
a6b0c0a to
0676fba
Compare
icewind1991
reviewed
Feb 25, 2026
CarlSchwan
force-pushed
the
carl/perf-delete-share
branch
from
205b302 to
981381b
Compare
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/perf-delete-share
branch
from
981381b to
4acb3b5
Compare
cristianscheid
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First check which users have a shares and for which providers and then only load these shares.
Avoid doing at most 5 SQL queries for each users a share was shared with if there are no shares.
Checklist
3. to review, feature component)stable32)