Skip to content

Add new sbwf BAM_VARIANT_CALLING_MPILEUP_BCFTOOLS#10283

Merged
LouisLeNezet merged 22 commits intonf-core:masterfrom
LouisLeNezet:bam_gl_bcftools
Mar 2, 2026
Merged

Add new sbwf BAM_VARIANT_CALLING_MPILEUP_BCFTOOLS#10283
LouisLeNezet merged 22 commits intonf-core:masterfrom
LouisLeNezet:bam_gl_bcftools

Conversation

@LouisLeNezet
Copy link
Contributor

@LouisLeNezet LouisLeNezet commented Feb 27, 2026

PR checklist

This PR introduce a new subworkflow to call variant from multi sample bam file for multiple chromosome.
The merging of sample is done in the subworkflow and the merging by chromosome is delegated to VCF_GATHER_BCFTOOLS.

I'm wondering if the latter should also perform the gathering by sample.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@LouisLeNezet LouisLeNezet self-assigned this Feb 27, 2026
LouisLeNezet and others added 4 commits February 27, 2026 17:58
….yml

Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
@LouisLeNezet LouisLeNezet requested a review from maxulysse March 2, 2026 12:49
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor comments

@LouisLeNezet LouisLeNezet added this pull request to the merge queue Mar 2, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 2, 2026
@LouisLeNezet LouisLeNezet added this pull request to the merge queue Mar 2, 2026
Merged via the queue into nf-core:master with commit 3d9c2f4 Mar 2, 2026
68 checks passed
@LouisLeNezet LouisLeNezet deleted the bam_gl_bcftools branch March 2, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants