Skip to content

Fix strict syntax in utils_* subworkflows #12329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itrujnara wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix strict syntax in utils_* subworkflows #12329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
253c4f8
Fix strict syntax in utils_* subworkflows
itrujnara Jul 9, 2026
e96cef9
Rename test to make linter happy
itrujnara Jul 9, 2026
dceaa3f
Add missing test tag in utils_nextflow_pipeline
itrujnara Jul 9, 2026
4af82ae
switch quote style for tags
mashehu Jul 9, 2026
c9ef49c
Merge branch 'master' into strict_syntax
itrujnara Jul 9, 2026
a031940
Merge branch 'master' into strict_syntax
itrujnara Jul 9, 2026
fd53495
Merge branch 'master' into strict_syntax
itrujnara Jul 9, 2026
09b8335
Merge branch 'master' into strict_syntax
itrujnara Jul 9, 2026
2d54e53
Merge branch 'master' into strict_syntax
itrujnara Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion subworkflows/nf-core/utils_nextflow_pipeline/main.nf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ workflow UTILS_NEXTFLOW_PIPELINE {
}

emit:
dummy_emit = true
true
}

/*
Expand Down
2 changes: 1 addition & 1 deletion subworkflows/nf-core/utils_nextflow_pipeline/meta.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ input:
description: |
Check if the conda channel priority is correct.
output:
- dummy_emit:
- "true":
type: boolean
description: |
Dummy emit to make nf-core subworkflows lint happy
Comment thread
mashehu marked this conversation as resolved.
Expand Down
8 changes: 5 additions & 3 deletions ...flow_pipeline/tests/main.function.nf.test → ...tils_nextflow_pipeline/tests/main.nf.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@ nextflow_function {
name "Test Functions"
script "subworkflows/nf-core/utils_nextflow_pipeline/main.nf"
config "subworkflows/nf-core/utils_nextflow_pipeline/tests/nextflow.config"
tag 'subworkflows'
tag 'utils_nextflow_pipeline'
tag 'subworkflows/utils_nextflow_pipeline'

tag "subworkflows"
tag "subworkflows_nfcore"
tag "utils_nextflow_pipeline"
tag "subworkflows/utils_nextflow_pipeline"

test("Test Function getWorkflowVersion") {

Expand Down
0 ...pipeline/tests/main.function.nf.test.snap → ...nextflow_pipeline/tests/main.nf.test.snap
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion subworkflows/nf-core/utils_nfcore_pipeline/main.nf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ workflow UTILS_NFCORE_PIPELINE {
checkProfileProvided(nextflow_cli_args)

emit:
valid_config = valid_config
valid_config

@mashehu mashehu Jul 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we needed this for strict syntax a3fb735

@itrujnara itrujnara Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find the documentation for this, but nextflow lint shows a warning if a workflow has a single output and it is named. I have sent the warning message on Slack. I agree with Maxime that this rule should not be there, but that's the way Ben designed it.

@mashehu mashehu Jul 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but in the current way i get the following with nextflow 26.04.4:

Warn  subworkflows/nf-core/utils_nfcore_pipeline/main.nf:16:5: Variable was declared but not used
│  16 |     valid_config = checkConfigProvided()
╰     |     ^^^^^^^^^^^^

Warn  subworkflows/nf-core/utils_nfcore_pipeline/main.nf:20:5: Emit name should be omitted when there is only one emit
│  20 |     valid_config
╰     |     ^^^^^^^^^^^^

that's why I had the previous version

@itrujnara itrujnara Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must have tested with a wrong version, with 26.04.4 it indeed returns these warnings. According to the docs the version without the extra name is correct. I am puzzled as to how I should write the emit section to avoid complaints from the language server.

}

/*
Expand Down
2 changes: 1 addition & 1 deletion subworkflows/nf-core/utils_nfcore_pipeline/meta.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ input:
description: |
Nextflow CLI positional arguments
output:
- success:
- valid_config:
type: boolean
description: |
Dummy output to indicate success
Expand Down
2 changes: 1 addition & 1 deletion subworkflows/nf-core/utils_nfschema_plugin/main.nf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,5 +73,5 @@ workflow UTILS_NFSCHEMA_PLUGIN {
}

emit:
dummy_emit = true
true
}
2 changes: 1 addition & 1 deletion subworkflows/nf-core/utils_nfschema_plugin/meta.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ input:
Whether to apply typecasting to the parameters given via the CLI before validation.
Set this to `null` to use the default behavior.
output:
- dummy_emit:
- "true":
type: boolean
description: Dummy emit to make nf-core subworkflows lint happy
authors:
Expand Down