Skip to content

Add new module: octopusv/plotcircos#12374

Open
manascripts wants to merge 6 commits into
nf-core:masterfrom
manascripts:octopusv-plot-circos
Open

Add new module: octopusv/plotcircos#12374
manascripts wants to merge 6 commits into
nf-core:masterfrom
manascripts:octopusv-plot-circos

Conversation

@manascripts

Copy link
Copy Markdown
Member

This PR adds octopusv/plotcircos module.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Comment thread modules/nf-core/octopusv/plotcircos/main.nf
Comment thread modules/nf-core/octopusv/plotcircos/tests/main.nf.test Outdated
Comment on lines +31 to +32
file(process.out.circos.get(0).get(1)),
process.out.findAll { key, val -> key.startsWith('versions') }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
file(process.out.circos.get(0).get(1)),
process.out.findAll { key, val -> key.startsWith('versions') }
sanitizeOutput(process.out, unstableKeys: ["oversized_intra"])

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worked with the entire output as well actually

@manascripts
manascripts force-pushed the octopusv-plot-circos branch from 996fbdd to 0c4ae1f Compare July 16, 2026 08:13
@manascripts

Copy link
Copy Markdown
Member Author

The PDF checksum is unstable (metadata), maybe fixable with sanitizeOutput but the version command also seems to be problematic, switching back to the python command.

@mashehu

mashehu commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

what's the problem with the version command?

@mashehu

mashehu commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

oh, I see, it doesn't work in conda? weird I tested it locally...

@manascripts

Copy link
Copy Markdown
Member Author

Yes, it's strange.
I was using nf-test test so didn't know this was failing. Will update in a bit.

@manascripts
manascripts force-pushed the octopusv-plot-circos branch from b4bd876 to 169fe99 Compare July 16, 2026 11:52
@manascripts

manascripts commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

Finally it worked with the png, there seems to be an issue with the pdf checksum (even with sanitizeOutput), can add a test and capture the name or something, if you'd like!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants