Skip to content

Add padding between switch and its label#3010

Merged
rajsite merged 8 commits into
mainfrom
users/makinc/switch-padding
Jul 10, 2026
Merged

Add padding between switch and its label#3010
rajsite merged 8 commits into
mainfrom
users/makinc/switch-padding

Conversation

@m-akinc

@m-akinc m-akinc commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Pull Request

🤨 Rationale

The nimble-switch design dictates that there should be a two-pixel gap/padding between the label and control:
image

Needed for AzDO bug: https://dev.azure.com/ni/DevCentral/_workitems/edit/3957974

👩‍💻 Implementation

There is not an existing 2-pixel padding/spacing token, and I'm not sure we need one. I just added a hard-coded 2px bottom padding to the label element.

🧪 Testing

Verified in Storybook.

@m-akinc m-akinc requested review from jattasNI and rajsite as code owners July 9, 2026 23:31
@m-akinc m-akinc changed the title Users/makinc/switch padding Add padding between switch and its label Jul 9, 2026
Comment thread packages/nimble-components/src/switch/styles.ts
rajsite and others added 5 commits July 10, 2026 11:47
@rajsite rajsite merged commit 4817316 into main Jul 10, 2026
14 of 16 checks passed
@rajsite rajsite deleted the users/makinc/switch-padding branch July 10, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants