Skip to content

Add padding between switch and its label #3010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rajsite merged 8 commits into from
Jul 10, 2026
Merged

Add padding between switch and its label #3010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
acf0004
Change files
m-akinc Jul 9, 2026
9cef52f
Add padding between switch and its label
m-akinc Jul 9, 2026
b6cd053
Merge branch 'main' into users/makinc/switch-padding
m-akinc Jul 9, 2026
febc35b
Apply suggestions from code review
rajsite Jul 10, 2026
3ff5900
fix patch
rajsite Jul 10, 2026
c39495e
more fix patch
rajsite Jul 10, 2026
8aa0dc3
ugh
rajsite Jul 10, 2026
35fc6b6
comment
rajsite Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@ni-nimble-components-46a29ba0-9f17-47f3-8087-e11186e45247.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Add padding between switch and its label",
"packageName": "@ni/nimble-components",
"email": "7282195+m-akinc@users.noreply.github.com",
"dependentChangeType": "patch"
}
10 changes: 6 additions & 4 deletions packages/nimble-components/src/switch/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import {
borderWidth,
buttonLabelDisabledFontColor,
buttonLabelFontColor,
controlHeight,
controlLabelDisabledFontColor,
controlLabelFont,
controlLabelFontColor,
Expand All @@ -38,9 +37,6 @@ export const styles = css`
--ni-private-switch-indicator-size: 24px;
--ni-private-switch-indicator-inner-size: 18px;
--ni-private-switch-indicator-margin: -2px;
padding-bottom: calc(
${controlHeight} - var(--ni-private-switch-height)
);
}

:host([disabled]) {
Expand All @@ -65,6 +61,12 @@ export const styles = css`
.switch-container {
display: flex;
align-items: center;
${'' /*
Reserve space around the 24px control to fill a 32px height until we have a switch 32 design.
See: https://github.com/ni/nimble/issues/3013
*/}
padding-top: 2px;
padding-bottom: 6px;
}

slot[name='unchecked-message']::slotted(*) {
Expand Down