Skip to content

fix(share-pnl): render brand mark only across all covers#164

Merged
metodi96 merged 1 commit into
mainfrom
fix/share-pnl-mark-only
May 15, 2026
Merged

fix(share-pnl): render brand mark only across all covers#164
metodi96 merged 1 commit into
mainfrom
fix/share-pnl-mark-only

Conversation

@metodi96
Copy link
Copy Markdown
Collaborator

Summary

Make all three Share-PnL covers render the Nolus brand mark only — covers 2 (orange) and 3 (lavender) were drawing the full mark + "nolus" wordmark, while cover 1 (dark navy) appeared mark-only only because its wordmark color blended into the background. The three previews now look visually consistent.

Changes

  • SharePnLDialog.vue: crop the logo SVG to the left 32x32 mark (drawImage(image, 0, 0, 32, 32, 80, 80, 64, 64)) instead of drawing the full 126x32 mark+wordmark
  • Drop the now-unused logo: "light" | "dark" field from Palette and all 3 palette entries
  • Drop the logoDark import and delete the orphan src/assets/icons/logo-dark.svg
  • Rename the remaining import to nolusLogo since the logoLight name no longer reflects what the file is used for

Verification

  • vue-tsc --noEmit passed clean
  • eslint src/modules/leases/components/single-lease/SharePnLDialog.vue passed clean
  • Pre-commit hook ran the full lint + vitest + vite build pipeline successfully
  • Visual check expected from the reviewer: open the Share-PnL dialog on a lease and confirm all three thumbnails show only the orange "N" mark in the top-left

Covers 2 (orange) and 3 (lavender) were drawing the full mark+wordmark
logo while cover 1 (dark navy) appeared mark-only because its wordmark
color blended into the background. Crop the SVG to the 32x32 mark on
every cover so the three previews are visually consistent. Drop the
now-unused logo-dark.svg asset and the per-palette logo variant field.
@metodi96 metodi96 merged commit e798265 into main May 15, 2026
2 checks passed
@metodi96 metodi96 deleted the fix/share-pnl-mark-only branch May 15, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant