fix(share-pnl): render brand mark only across all covers#164
Merged
Conversation
Covers 2 (orange) and 3 (lavender) were drawing the full mark+wordmark logo while cover 1 (dark navy) appeared mark-only because its wordmark color blended into the background. Crop the SVG to the 32x32 mark on every cover so the three previews are visually consistent. Drop the now-unused logo-dark.svg asset and the per-palette logo variant field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make all three Share-PnL covers render the Nolus brand mark only — covers 2 (orange) and 3 (lavender) were drawing the full mark + "nolus" wordmark, while cover 1 (dark navy) appeared mark-only only because its wordmark color blended into the background. The three previews now look visually consistent.
Changes
SharePnLDialog.vue: crop the logo SVG to the left 32x32 mark (drawImage(image, 0, 0, 32, 32, 80, 80, 64, 64)) instead of drawing the full 126x32 mark+wordmarklogo: "light" | "dark"field fromPaletteand all 3 palette entrieslogoDarkimport and delete the orphansrc/assets/icons/logo-dark.svgnolusLogosince thelogoLightname no longer reflects what the file is used forVerification
vue-tsc --noEmitpassed cleaneslint src/modules/leases/components/single-lease/SharePnLDialog.vuepassed clean