Skip to content

fix(share-pnl): render brand mark only across all covers #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
metodi96 merged 1 commit into from
May 15, 2026
Merged

fix(share-pnl): render brand mark only across all covers #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/assets/icons/logo-dark.svg
View file
Open in desktop

This file was deleted.

33 changes: 14 additions & 19 deletions src/modules/leases/components/single-lease/SharePnLDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,7 @@ import { useI18n } from "vue-i18n";
import shareImageTwo from "@/assets/icons/share-image-2.png?url";
import shareImageThree from "@/assets/icons/share-image-3.png?url";
import shareImageFour from "@/assets/icons/share-image-4.png?url";
import logoLight from "@/assets/icons/logo-light.svg?url";
import logoDark from "@/assets/icons/logo-dark.svg?url";
import nolusLogo from "@/assets/icons/logo-light.svg?url";
import type { LeaseInfo } from "@/common/api";
import type { LeaseDisplayData } from "@/common/stores/leases";
import { NATIVE_CURRENCY } from "@/config/global";
Expand All @@ -114,16 +113,15 @@ const showPositionSize = ref(true);
type Palette = {
text: string;
muted: string;
logo: "light" | "dark";
};

// Per-cover palette covers text + logo variant only. PnL colors are a single
// brand pair (PNL_POSITIVE / PNL_NEGATIVE) used on every cover for visual
// Per-cover palette covers text colors only. PnL colors are a single brand
// pair (PNL_POSITIVE / PNL_NEGATIVE) used on every cover for visual
// consistency across the share library.
const palettes: Palette[] = [
{ text: "#FFFFFF", muted: "#C1CAD7", logo: "light" }, // dark navy illustration
{ text: "#082D63", muted: "#5E7699", logo: "dark" }, // orange
{ text: "#082D63", muted: "#5E7699", logo: "dark" } // light lavender
{ text: "#FFFFFF", muted: "#C1CAD7" }, // dark navy illustration
{ text: "#082D63", muted: "#5E7699" }, // orange
{ text: "#082D63", muted: "#5E7699" } // light lavender
];

const PNL_POSITIVE = "#1AB171";
Expand Down Expand Up @@ -392,23 +390,20 @@ function setPositionMetaRow(ctx: CanvasRenderingContext2D) {
}
}

// Render the Nolus logo (mark + wordmark) top-left of the canvas. Uses
// logo-light.svg on dark covers, logo-dark.svg on light covers. The logo SVG
// is 126x32 native; rendered at 2x = 252x64. Awaited so the image.onload
// paints before the next render's setBackground overwrites the bitmap.
// Render the Nolus brand mark top-left of the canvas. The source SVG is
// 126x32 with the 32x32 mark on the left followed by the "nolus" wordmark;
// we crop to the mark only so every cover shows the same compact glyph
// (the wordmark would blend into the dark navy cover anyway). Awaited so
// image.onload paints before the next render's setBackground overwrites
// the bitmap.
async function setLogo(ctx: CanvasRenderingContext2D) {
const variant = palette().logo;
const src = variant === "light" ? logoLight : logoDark;

const image = new Image();
const data = await fetch(src);
const data = await fetch(nolusLogo);
const blob = await data.blob();

return new Promise<void>((resolve) => {
image.onload = () => {
const w = 252;
const h = 64;
ctx.drawImage(image, 80, 80, w, h);
ctx.drawImage(image, 0, 0, 32, 32, 80, 80, 64, 64);
resolve();
};
image.src = window.URL.createObjectURL(blob);
Expand Down
Loading