Skip to content

Conversation

@morinokami
Copy link
Contributor

I have added all missing Japanese translations. I confirmed that all keys are translated by running the pnpm i18n:check ja-JP command.

@vercel
Copy link

vercel bot commented Feb 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 11, 2026 8:11am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 11, 2026 8:11am
npmx-lunaria Ignored Ignored Feb 11, 2026 8:11am

Request Review

@github-actions
Copy link

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/en-GB.json Localization changed, will be marked as complete.
lunaria/files/en-US.json Source changed, localizations will be marked as outdated.
lunaria/files/ja-JP.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2026

📝 Walkthrough

Walkthrough

This pull request updates internationalisation locale files across English and Japanese languages. It applies a trailing period punctuation fix to the show_low_usage_tooltip text across English locale variants (en-GB and en-US). The Japanese locale files receive significant structural expansions, introducing new translation keys for keyboard shortcuts, data source configuration, security downgrades, trend visualisations, size formatting, and accessibility sections. The additions are purely additive without removing existing keys.

Possibly related PRs

Suggested reviewers

  • danielroe
  • serhalp
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description directly relates to the changeset, which involves adding missing Japanese translations to locale files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroe danielroe added this pull request to the merge queue Feb 11, 2026
Merged via the queue into npmx-dev:main with commit 7083e4b Feb 11, 2026
17 checks passed
@github-actions
Copy link

Thanks for your first contribution, @morinokami! 🎊

We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role.

Comment on lines 296 to +298
"recent_versions_only_tooltip": "Show only versions published within the last year.",
"show_low_usage": "Show low usage versions",
"show_low_usage_tooltip": "Include version groups with less than 1% of total downloads",
"show_low_usage_tooltip": "Include version groups with less than 1% of total downloads.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is unrelated to the Japanese translations, but although both recent_versions_only_tooltip and show_low_usage_tooltip are sentences displayed inside a tooltip, only show_low_usage_tooltip was missing a comma, so I added one for consistency.

Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants