fix: stop returning private key to renderer on export#29
Closed
0x-SquidSol wants to merge 1 commit intonullxnothing:mainfrom
Closed
fix: stop returning private key to renderer on export#290x-SquidSol wants to merge 1 commit intonullxnothing:mainfrom
0x-SquidSol wants to merge 1 commit intonullxnothing:mainfrom
Conversation
The export-private-key IPC handler was returning the raw key string back to the renderer process after copying it to the clipboard. This unnecessarily exposed private key material across the IPC bridge. The handler now returns a success flag and the renderer displays a clipboard confirmation message instead of the plaintext key. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
|
The runtime behavior here makes sense, but the renderer contract also needs to be updated. wallet:export-private-key would now return rue, while src/types/daemon.d.ts still declares �xportPrivateKey: (walletId: string) => Promise<IpcResponse>. Please update the preload/type surface so the IPC contract matches the new behavior. |
Owner
|
Closed as superseded by #75, which reapplies the corrected security hardening on top of current main. This avoids merging stale/conflicted branches and preserves the fixes with passing CI/CodeQL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wallet:export-private-keyIPC handler was returning the raw private key string to the renderer process after already copying it to the clipboardTest plan
pnpm run typecheck— passes cleanpnpm run test— all wallet tests pass (19/19)