Skip to content

fix: stop returning private key to renderer on export #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0x-SquidSol wants to merge 1 commit into from
Closed

fix: stop returning private key to renderer on export #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion electron/ipc/wallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,6 @@ export function registerWalletHandlers() {
setTimeout(() => {
if (clipboard.readText() === keyString) clipboard.writeText('')
}, 30000)
return keyString
return true
}))
}
4 changes: 2 additions & 2 deletions src/panels/WalletPanel/tabs/AgentsTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ export function AgentsTab() {
const handleExportConfirm = useCallback(async () => {
if (!activeWalletId || exportConfirmText !== 'EXPORT') return
const res = await window.daemon.wallet.exportPrivateKey(activeWalletId)
if (res.ok && res.data) {
setRevealedKey(res.data as string)
if (res.ok) {
setRevealedKey('Copied to clipboard. Auto-clears in 30s.')
setExportConfirmText('')
setTimeout(() => { setRevealedKey(null); clearAction() }, 5000)
} else { setError(res.error ?? 'Export failed') }
Expand Down
4 changes: 2 additions & 2 deletions src/panels/WalletPanel/tabs/WalletTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,8 @@ export function WalletTab({ onRefresh }: Props) {
const handleExportKeyConfirm = async () => {
if (!exportConfirmId || exportConfirmText !== 'EXPORT') return
const res = await window.daemon.wallet.exportPrivateKey(exportConfirmId)
if (res.ok && res.data) {
setRevealKeyId(exportConfirmId); setRevealedKey(res.data)
if (res.ok) {
setRevealKeyId(exportConfirmId); setRevealedKey('Copied to clipboard. Auto-clears in 30s.')
setExportConfirmId(null); setExportConfirmText('')
setTimeout(() => { setRevealKeyId(null); setRevealedKey(null) }, 5_000)
} else {
Expand Down