fix: validate environment variable key names before writing to .env files#38
Closed
0x-SquidSol wants to merge 1 commit intonullxnothing:mainfrom
Closed
fix: validate environment variable key names before writing to .env files#380x-SquidSol wants to merge 1 commit intonullxnothing:mainfrom
0x-SquidSol wants to merge 1 commit intonullxnothing:mainfrom
Conversation
…iles writeEnvVar and addEnvVar accepted arbitrary key names without validation. A key containing shell metacharacters (e.g. KEY=$(cmd)) could cause command injection when the .env file is sourced. Both functions now reject keys that don't match the POSIX standard for environment variable names. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
|
Closed as superseded by #75, which reapplies the corrected security hardening on top of current main. This avoids merging stale/conflicted branches and preserves the fixes with passing CI/CodeQL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
writeEnvVarandaddEnvVaraccepted arbitrary key names without validationKEY=$(cmd)) could cause command injection when the .env file is sourced by a shell/^[A-Za-z_][A-Za-z0-9_]*$/) and reject invalid namesTest plan
MY_KEY) — verify it works$(cmd)in the name — verify it throwspnpm run typecheck— passes cleanpnpm run test— 234/234 pass (10 pre-existing failures unrelated)