Skip to content

fix: validate environment variable key names before writing to .env files #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0x-SquidSol wants to merge 1 commit into from
Closed

fix: validate environment variable key names before writing to .env files #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions electron/services/EnvService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ const SECRET_PATTERNS: Array<{ pattern: string; label: string }> = [
]

const ENV_FILE_NAMES = ['.env', '.env.local', '.env.production', '.env.staging', '.env.development']
const VALID_ENV_KEY = /^[A-Za-z_][A-Za-z0-9_]*$/
const VERCEL_TOKEN_PATTERN = /^[A-Za-z0-9]{24,}$/
const VERCEL_API_BASE = 'https://api.vercel.com'

Expand Down Expand Up @@ -152,6 +153,7 @@ export function scanAllProjects(): UnifiedKey[] {
}

export function writeEnvVar(filePath: string, key: string, newValue: string): void {
if (!VALID_ENV_KEY.test(key)) throw new Error(`Invalid environment variable name: "${key}"`)
const content = fs.readFileSync(filePath, 'utf8')
const lines = content.split('\n')
let found = false
Expand Down Expand Up @@ -186,6 +188,7 @@ export function writeEnvVar(filePath: string, key: string, newValue: string): vo
}

export function addEnvVar(filePath: string, key: string, value: string): void {
if (!VALID_ENV_KEY.test(key)) throw new Error(`Invalid environment variable name: "${key}"`)
let content = ''
if (fs.existsSync(filePath)) {
content = fs.readFileSync(filePath, 'utf8')
Expand Down