Add support for twitter cards (full image viewer only) (rebased onto metadata52) (rebased onto metadata53)#5216
Merged
joshmoore merged 7 commits intoome:metadata53from Apr 7, 2017
atarkowska:rebased/metadata53/rebased/metadata52/twittercards
Merged
Add support for twitter cards (full image viewer only) (rebased onto metadata52) (rebased onto metadata53)#5216joshmoore merged 7 commits intoome:metadata53from atarkowska:rebased/metadata53/rebased/metadata52/twittercards
joshmoore merged 7 commits intoome:metadata53from
atarkowska:rebased/metadata53/rebased/metadata52/twittercards
Conversation
Rename property as omero.web.sharing.twitter to provide a namespace for other sharing options.
Member
Author
|
--rebased-from #4613 |
Member
|
In a follow-up (when @manics is back) we may need to address #4613 (comment) |
Member
|
--rebased-to #5795 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same as gh-4613 but rebased onto metadata53.
This is the same as gh-4260 but rebased onto metadata52.
I've had this lurking around since January 2014. Given that we now have a public resource and Twitter no longer require manual approvals I thought it's time to resurrect it. See https://dev.twitter.com/cards/types/summary-large-image
The
titleanddescriptionfields are mandatory, I'm assuming there will always be a non-empty image name, description is set to the owner's name if empty.At risk of stating the obvious this can only be tested with a public image on an external server. Open an image in the full image viewer, copy the url into a tweet.