Add support for twitter cards (full image viewer only) (rebased onto metadata52) (rebased onto metadata53) (rebased onto metadata54)#5795
Closed
manics wants to merge 9 commits intoome:metadata54from
Conversation
Rename property as omero.web.sharing.twitter to provide a namespace for other sharing options.
Member
Author
|
--rebased-from #5216 |
Member
Author
|
--rebased-from #5245 |
Member
|
Is this a discrepancy between metadata54 and develop? |
Member
Author
|
I can't find any sign of it on the current develop |
Member
|
Then likely best to open that (instead/as well) against develop and we get it tested in the mainline. Then we can merge 5.4.7 into metadata54. |
Member
Author
|
--rebased-to #5796 |
Member
Author
|
--rebased-to #5797 |
Member
Author
|
This should be upstream now |
manics
deleted the
rebased/metadata54/rebased/metadata53/rebased/metadata52/twittercards
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same as gh-5216 gh-4613 gh-4260 but rebased onto metadata54.
Includes gh-5245 rebased onto metadata54.
I've had this lurking around since January 2014. Given that we now have a public resource and Twitter no longer require manual approvals I thought it's time to resurrect it. See https://dev.twitter.com/cards/types/summary-large-image
The
titleanddescriptionfields are mandatory, I'm assuming there will always be a non-empty image name, description is set to the owner's name if empty.At risk of stating the obvious this can only be tested with a public image on an external server. Open an image in the full image viewer, copy the url into a tweet.