Social media absolute url config#5245
Merged
joshmoore merged 1 commit intoome:metadata53from Apr 19, 2017
Merged
Conversation
Member
Author
|
--rebased-from #4744 |
Member
|
works as expected with #5244 |
This was referenced Jun 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Allows absolute URL for social media to be overriden by the OMERO.web administrator, the default is to use Django's
build_absolute_uriwhich probably uses theHostheader sent by the client.--depends-on #5244
In conjunction with #5244 this includes all required changes from #4744 (some commits were already rebased to develop, others are unnecessary following the addition of
omero.web.api.absolute_urlin mainline.Testing this PR
omero.web.api.absolute_url, check this is reflected in the hard-coded URL.Related reading
https://trello.com/c/z2U5K6ht/1-omero-5-3-migration
@aleksandra-tarkowska