Skip to content

Use accessors (new, get, set) instead of direct field access #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gab-arrobo merged 2 commits into from
Jun 6, 2026
+10 −13
Merged

Use accessors (new, get, set) instead of direct field access #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7fbf65
Use accessors (new, get, set) instead of direct field access
gab-arrobo Jun 6, 2026
3ed2396
Address Copilot's comment
gab-arrobo Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions nrfcache/nrfcache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ func (npq NfProfilePriorityQ) at(index int) *NfProfileItem {

// push - adds an entry to the priority queue. Invokes heap api to
// push the entry to the correct location in the queue
func (npq *NfProfilePriorityQ) push(item interface{}) {
func (npq *NfProfilePriorityQ) push(item *NfProfileItem) {
heap.Push(npq, item)
}

Expand All @@ -98,15 +98,15 @@ func (npq *NfProfilePriorityQ) remove(item *NfProfileItem) {
}

// Push - implemented for heap interface. appends an element to the priority queue
func (npq *NfProfilePriorityQ) Push(item interface{}) {
func (npq *NfProfilePriorityQ) Push(item any) {
n := len(*npq)
entry := item.(*NfProfileItem)
entry.index = n
*npq = append(*npq, entry)
}

// Pop - implemented for heap interface. Removes the entry with expiry time
func (npq *NfProfilePriorityQ) Pop() interface{} {
func (npq *NfProfilePriorityQ) Pop() any {
old := *npq
n := len(old)
item := old[n-1]
Expand Down
17 changes: 7 additions & 10 deletions nrfcache/nrfcache_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1111,15 +1111,12 @@ func TestCacheKeyBehavior(t *testing.T) {
// Check if the MatchAmfProfile function is working correctly
func TestAmfProfileMatching(t *testing.T) {
// Create a test AMF profile
amfProfile := models.NFProfileDiscovery{
NfInstanceId: "9f7d5a3f-88ab-4525-b31e-334da7faedab",
NfType: models.NFTYPE_AMF,
PlmnList: []models.PlmnId{{Mcc: "208", Mnc: "93"}},
AmfInfo: &models.AmfInfo{
AmfRegionId: "ca",
AmfSetId: "3f8",
},
}
amfProfile := models.NewNFProfileDiscovery("9f7d5a3f-88ab-4525-b31e-334da7faedab", models.NFTYPE_AMF, models.NFSTATUS_REGISTERED)
amfProfile.SetPlmnList([]models.PlmnId{{Mcc: "208", Mnc: "93"}})
amfProfile.SetAmfInfo(models.AmfInfo{
AmfRegionId: "ca",
AmfSetId: "3f8",
})

testCases := []struct {
param Nnrf_NFDiscovery.ApiSearchNFInstancesRequest
Expand All @@ -1140,7 +1137,7 @@ func TestAmfProfileMatching(t *testing.T) {

for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
match, err := MatchAmfProfile(&amfProfile, tc.param)
match, err := MatchAmfProfile(amfProfile, tc.param)
if err != nil {
t.Fatalf("MatchAmfProfile failed: %v", err)
}
Expand Down
Loading