Fix profiles data model attribute count parameter name and timestamp doc unit#8514
Draft
thswlsqls wants to merge 1 commit into
Draft
Fix profiles data model attribute count parameter name and timestamp doc unit#8514thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
…doc unit ProfileData.create's parameter was named droppedAttributesCount, but the value is exposed via getTotalAttributeCount() and ProfileMarshaler derives the dropped count as total minus attached attributes, mirroring the Span family. Rename the parameter to totalAttributeCount to match the getter. SampleData.getTimestamps() javadoc said timestamps are in ms, but SampleMarshaler serializes them to the timestamps_unix_nano field and they must fall within the profile's nanosecond time range. Fix the unit to nanoseconds.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8514 +/- ##
=========================================
Coverage 78.77% 78.77%
Complexity 8579 8579
=========================================
Files 1009 1009
Lines 28993 28993
Branches 3599 3599
=========================================
Hits 22839 22839
Misses 5311 5311
Partials 843 843 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ProfileData.create(...)'s 11th parameter is nameddroppedAttributesCount, but the value is exposed viagetTotalAttributeCount()andProfileMarshalerderives dropped from it (getTotalAttributeCount() - getAttributeIndices().size()). It holds the total, not the dropped count, so the name misleads callers. Rename it tototalAttributeCount.droppedAttributesCount = getTotalAttributeCount() - getAttributes().size()(e.g.SpanMarshaler,LogStatelessMarshaler).SampleData.getTimestamps()javadoc said "represented in ms", butSampleMarshalerserializes totimestamps_unix_nanoand the timestamps must fall within the profile's nanosecond range (ProfileData.getTimeNanos()). Fix the unit to nanoseconds.Testing done
docs/apidiffsupdate is needed. Not user-facing, so no CHANGELOG entry../gradlew :sdk:profiles:checkpassed (test + spotlessCheck + ErrorProne/NullAway + jApiCmp).