Skip to content

Fix profiles data model attribute count parameter name and timestamp doc unit #8514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thswlsqls wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Draft

Fix profiles data model attribute count parameter name and timestamp doc unit #8514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/profiles/src/main/java/io/opentelemetry/sdk/profiles/data/ProfileData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ static ProfileData create(
ValueTypeData periodType,
long period,
String profileId,
int droppedAttributesCount,
int totalAttributeCount,
String originalPayloadFormat,
ByteBuffer originalPayload,
List<Integer> attributeIndices) {
Expand All @@ -54,7 +54,7 @@ static ProfileData create(
periodType,
period,
profileId,
droppedAttributesCount,
totalAttributeCount,
originalPayloadFormat,
originalPayload,
attributeIndices);
Expand Down
4 changes: 2 additions & 2 deletions sdk/profiles/src/main/java/io/opentelemetry/sdk/profiles/data/SampleData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ static SampleData create(
List<Long> getValues();

/**
* Timestamps associated with Sample represented in ms. These timestamps are expected to fall
* within the Profile's time range.
* Timestamps associated with Sample represented as nanoseconds past the epoch. These timestamps
* are expected to fall within the Profile's time range.
*/
List<Long> getTimestamps();
}
Loading