Conversation
tpd-opitz
reviewed
Aug 26, 2025
| log.debug(f"Zähler {meter_type} mit Modbus-ID:{modbus_id} antwortet nicht.") | ||
| except Exception: | ||
| log.debug(client) | ||
| log.debug(f"Zähler {meter_type} mit Modbus-ID:{modbus_id} antwortet nicht.") |
Contributor
There was a problem hiding this comment.
wäre es hier nicht hilfreich, die Nachricht aus der Exception mit auszugeben?
Und wäre es nicht besser als "Warning" oder gar als "Error" geloggt?
Contributor
Author
There was a problem hiding this comment.
Es wird geprüft, auf welcher Modbus-ID der Zähler antwortet, um den Zählertyp zu bestimmen. Die Exception ist erwartetes Verhalten. Kunden werden dagegen nervös, wenn bei jedem Start Warning oder Error im Log steht, auch wenn alles funktioniert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.