Skip to content

fix b23 and mpm3pm #2701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LKuemmel merged 1 commit into from
Aug 26, 2025
Merged

fix b23 and mpm3pm #2701

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/modules/internal_chargepoint_handler/clients.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,16 +63,16 @@ def find_meter_client(meters: List[meter_config],
client: Union[ModbusSerialClient_, ModbusTcpClient_],
fault_state: FaultState) -> METERS:
for meter_type, modbus_id in meters:
meter_client = meter_type(modbus_id, client, fault_state)
with client:
try:
try:
with client:
meter_client = meter_type(modbus_id, client, fault_state)
if meter_client.get_voltages()[0] > 200:
with ModifyLoglevelContext(log, logging.DEBUG):
log.debug("Verbauter Zähler: "+str(meter_type)+" mit Modbus-ID: "+str(modbus_id))
return meter_client
except Exception:
log.debug(client)
log.debug(f"Zähler {meter_type} mit Modbus-ID:{modbus_id} antwortet nicht.")
except Exception:
log.debug(client)
log.debug(f"Zähler {meter_type} mit Modbus-ID:{modbus_id} antwortet nicht.")
Copy link
Contributor

@tpd-opitz tpd-opitz Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wäre es hier nicht hilfreich, die Nachricht aus der Exception mit auszugeben?
Und wäre es nicht besser als "Warning" oder gar als "Error" geloggt?

Copy link
Contributor Author

@LKuemmel LKuemmel Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Es wird geprüft, auf welcher Modbus-ID der Zähler antwortet, um den Zählertyp zu bestimmen. Die Exception ist erwartetes Verhalten. Kunden werden dagegen nervös, wenn bei jedem Start Warning oder Error im Log steht, auch wenn alles funktioniert.

else:
return None

Expand Down