Skip to content

Update temporary settings when saving permanent settings if unplugged#2781

Merged
LKuemmel merged 1 commit intoopenWB:masterfrom
LKuemmel:update_temporary_settings
Sep 24, 2025
Merged

Update temporary settings when saving permanent settings if unplugged#2781
LKuemmel merged 1 commit intoopenWB:masterfrom
LKuemmel:update_temporary_settings

Conversation

@LKuemmel
Copy link
Contributor

  • temporäre Einstellungen geändert, dann angesteckt -> temporäre Einstellungen werden beibehalten
  • angesteckt, dann temporäre Einstellungen geändert -> temporäre Einstellungen werden beibehalten
  • temporäre Einstellungen geändert, dann persistente gespeichert, dann angesteckt -> temporäre Einstellungen werden mit persistenten überschrieben
  • temporäre Einstellungen geändert, dann angesteckt, dann persistente gespeichert -> temporäre Einstellungen werden beibehalten

@LKuemmel LKuemmel added this to the 2.1.8 milestone Sep 24, 2025
@LKuemmel LKuemmel merged commit 6c94d5a into openWB:master Sep 24, 2025
1 check passed
@LKuemmel LKuemmel deleted the update_temporary_settings branch September 24, 2025 08:35
Comment on lines +345 to +348
if (((cp.chargepoint.data.set.charging_ev != -1 and
cp.chargepoint.data.set.charging_ev == vehicle.num) or
cp.chargepoint.data.config.ev == vehicle.num) and
cp.chargepoint.data.get.plug_state is False):
Copy link
Contributor

@tpd-opitz tpd-opitz Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wenn cp.chargepoint.data.set.charging_ev == vehicle.num kann es nicht gleichzeitig -1 sein.

Suggested change
if (((cp.chargepoint.data.set.charging_ev != -1 and
cp.chargepoint.data.set.charging_ev == vehicle.num) or
cp.chargepoint.data.config.ev == vehicle.num) and
cp.chargepoint.data.get.plug_state is False):
cp_data = cp.chargepoint.data
if cp_data.get.plug_state is False # Constant UNPLUGED?
and vehicle.num in (cp_data.config.ev, cp_data.set.charging_ev):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants