Skip to content

Update temporary settings when saving permanent settings if unplugged #2781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LKuemmel merged 1 commit into from
Sep 24, 2025
Merged

Update temporary settings when saving permanent settings if unplugged #2781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/helpermodules/subdata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,18 @@ def process_vehicle_charge_template_topic(self, var: Dict[str, ChargeTemplate],
if "ct"+index not in var:
var["ct"+index] = ChargeTemplate()
var["ct"+index].data = dataclass_from_dict(ChargeTemplateData, decode_payload(msg.payload))
# Temporäres ChargeTemplate aktualisieren, wenn persistentes geändert wird
for vehicle in self.ev_data.values():
if vehicle.data.charge_template == int(index):
for cp in self.cp_data.values():
if (((cp.chargepoint.data.set.charging_ev != -1 and
cp.chargepoint.data.set.charging_ev == vehicle.num) or
cp.chargepoint.data.config.ev == vehicle.num) and
cp.chargepoint.data.get.plug_state is False):
Comment on lines +345 to +348
Copy link
Contributor

@tpd-opitz tpd-opitz Sep 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wenn cp.chargepoint.data.set.charging_ev == vehicle.num kann es nicht gleichzeitig -1 sein.

Suggested change
if (((cp.chargepoint.data.set.charging_ev != -1 and
cp.chargepoint.data.set.charging_ev == vehicle.num) or
cp.chargepoint.data.config.ev == vehicle.num) and
cp.chargepoint.data.get.plug_state is False):
cp_data = cp.chargepoint.data
if cp_data.get.plug_state is False # Constant UNPLUGED?
and vehicle.num in (cp_data.config.ev, cp_data.set.charging_ev):

if decode_payload(msg.payload) == "":
Pub().pub(f"openWB/chargepoint/{cp.chargepoint.num}/set/charge_template", "")
else:
cp.chargepoint.update_charge_template(var["ct"+index])
except Exception:
log.exception("Fehler im subdata-Modul")

Expand Down