fix(completion): hide internal commands and suppress fish debug logs#21
Open
jeet-dekivadia wants to merge 2 commits into
Open
fix(completion): hide internal commands and suppress fish debug logs#21jeet-dekivadia wants to merge 2 commits into
jeet-dekivadia wants to merge 2 commits into
Conversation
Signed-off-by: Jeet Dekivadia <jeet.university@gmail.com>
Signed-off-by: Jeet Dekivadia <jeet.university@gmail.com>
Author
|
Small follow-up for review context. This patch is limited to completion behavior: hidden commands stay hidden at the shell-completion boundary, and the fish probe no longer writes debug noise to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/tmp/fish-debug.logWhy
The non-empty completion path already skips
child.Hidden, but the initial empty-input branch did not. An initial tab press could therefore expose internal commands such as__complete,@completion, and@manpages.The fish completion script also appended diagnostics from every tab-completion invocation to a fixed temporary file. Bash already suppresses the same internal probe's stderr. Applying the same behavior in fish avoids an unbounded cross-session debug log during normal CLI use.
Validation
git diff --checkgo test ./internal/autocomplete -count=1Remote Linux validation
git diff --check./scripts/bootstrap./scripts/lint./scripts/test