cmd/runtimetest: Add an app description#260
Closed
wking wants to merge 2 commits intoopencontainers:v1.0.0.rc1from
Closed
cmd/runtimetest: Add an app description#260wking wants to merge 2 commits intoopencontainers:v1.0.0.rc1from
wking wants to merge 2 commits intoopencontainers:v1.0.0.rc1from
Conversation
This just landed via [1] (hence the bump to an untagged commit). Generated with: $ godep update github.com/urfave/cli $ git add -A Godeps [1]: urfave/cli#543 Signed-off-by: W. Trevor King <wking@tremily.us>
As I recommended earlier in the context of checking for all configured
devices [1]. An example would be:
{
...
"linux": {
"devices": [
{
"path": "/dev/fuse",
...
}
],
},
"hooks": {
"prestart": [
{
"path": "/bin/rm",
"args": ["rm", "/dev/fuse"]
}
}
}
}
where the resulting container (when created by a conformant runtime)
would not have the /dev/fuse entry runtimetest's linux.devices check
is looking for.
[1]: opencontainers#211 (comment)
Signed-off-by: W. Trevor King <wking@tremily.us>
wking
force-pushed
the
runtimetest-coverage-caveat
branch
from
d4003d8 to
8cc67d1
Compare
|
Rejected |
Contributor
Author
|
On Tue, Oct 25, 2016 at 10:50:04PM -0700, Ma Shimiao wrote:
If it lands in v1.0.0.rc1, this commit will make it to master via #181 |
|
@wking would you mind to create new PR to contribute to master branch? |
|
Moved to #277 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I recommended earlier in the context of checking for all configured devices. An example would be:
where the resulting container (when created by a conformant runtime) would not have the
/dev/fuseentryruntimetest'slinux.devicescheck is looking for.This PR also bumps the urfave/cli dependency to pick up urfave/cli#543.