cmd/runtimetest: Add an app description#277
Conversation
wking
force-pushed
the
runtimetest-coverage-caveat-2
branch
from
580fd0f to
afbe433
Compare
|
LGTM |
|
I think there is no need to add test files in urfave/cli. |
|
On Tue, Nov 22, 2016 at 05:50:45PM -0800, Ma Shimiao wrote:
I'm just running ‘godep update github.com/urfave/cli’ (as quoted in |
|
I also tried to update urfave/cli and no test files were added. Maybe you need to update you godep version |
This landed via [1] which was released with v1.19.0. Bump to the most recent release to get the .1 bugfixes too [2]. Generated with: $ godep update github.com/urfave/cli godep: WARNING: Godep workspaces (./Godeps/_workspace) are deprecated and support for them will be removed when go1.8 is released. godep: WARNING: Go version (go1.7) & $GO15VENDOREXPERIMENT= wants to enable the vendor experiment, but disabling because a Godep workspace (Godeps/_workspace) exists $ git add -A Godeps [1]: urfave/cli#543 [2]: https://github.com/urfave/cli/blob/v1.19.1/CHANGELOG.md#1191---2016-11-21 Signed-off-by: W. Trevor King <wking@tremily.us>
As I recommended earlier in the context of checking for all configured
devices [1]. An example would be:
{
...
"linux": {
"devices": [
{
"path": "/dev/fuse",
...
}
],
},
"hooks": {
"prestart": [
{
"path": "/bin/rm",
"args": ["rm", "/dev/fuse"]
}
}
}
}
where the resulting container (when created by a conformant runtime)
would not have the /dev/fuse entry runtimetest's linux.devices check
is looking for.
[1]: opencontainers#211 (comment)
Signed-off-by: W. Trevor King <wking@tremily.us>
wking
force-pushed
the
runtimetest-coverage-caveat-2
branch
from
afbe433 to
4057aaf
Compare
|
On Tue, Nov 22, 2016 at 11:18:42PM -0800, Ma Shimiao wrote:
That was the problem, thanks :). urfave/cli tests dropped with With godep v75 the update printed two warnings: godep: WARNING: Godep workspaces (./Godeps/_workspace) are deprecated and support for them will be removed when go1.8 is released. I'm not familiar enough with Godep to know what (if anything) we're |
|
LGTM |
1 similar comment
|
LGTM |
4 participants
Cherry-picking #260 onto master.