OCPBUGS-80930 | Add VolumeAttributesClass e2e test manifests for Azure disk

[radeore]

Summary

• Added ultrassd-manifest.yaml with VolumeAttributesClass support for running
  Kubernetes external storage e2e tests against the managed-csi-ultrassd
  StorageClass.
• Added volumeattributesclass.yaml defining an UltraSSD-backed
  VolumeAttributesClass with custom IOPS and throughput parameters

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: f08de092-6b72-443f-bd5b-aaba588492f1

📥 Commits

Reviewing files that changed from the base of the PR and between 72cb5b6 and 6aaee72.

📒 Files selected for processing (2)

• test/e2e/azure-disk/ultrassd-manifest.yaml
• test/e2e/azure-disk/volumeattributesclass.yaml

✅ Files skipped from review due to trivial changes (2)

• test/e2e/azure-disk/ultrassd-manifest.yaml
• test/e2e/azure-disk/volumeattributesclass.yaml

---

📝 Walkthrough

Walkthrough

Two new files were added under test/e2e/azure-disk/. ultrassd-manifest.yaml is an e2e test manifest (ShortName: azuredisk) that reuses an existing StorageClass (FromExistingClassName: managed-csi-ultrassd), enables snapshot testing (SnapshotClass: FromName), sources volume attributes from file (VolumeAttributesClass: FromFile), and declares CSI DriverInfo for disk.csi.azure.com (size range 4Gi–16Ti, fstypes xfs,ext4, mount option dirsync), topology key topology.disk.csi.azure.com/zone, listed driver capabilities, and pod/PV timeouts. volumeattributesclass.yaml adds a VolumeAttributesClass named ultrassd-azuredisk-vac for disk.csi.azure.com with diskIOPSReadWrite: "1000" and diskMBpsReadWrite: "200".

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@test/e2e/azure-disk/ultrassd-manifest.yaml`:
- Line 28: Update the UltraSSD manifest so the storage class/property
onlineExpansion is set to true (change the current onlineExpansion: false to
onlineExpansion: true) to reflect Azure UltraSSD and CSI driver v1.34+ support
for online volume expansion; modify the ultrassd manifest entry that defines
onlineExpansion so e2e tests exercise online expansion scenarios correctly.

In `@test/e2e/azure-disk/volumeattributesclass.yaml`:
- Around line 6-8: Update the volumeattributesclass parameters to match the
Azure Disk CSI driver's documented casing by renaming DiskIOPSReadWrite ->
diskIOPSReadWrite and DiskMBpsReadWrite -> diskMBpsReadWrite in the YAML, and
verify that the numeric values (1000 IOPS, 200 MBps) are appropriate for the
intended disk SKU/size (since Azure enforces size-dependent IOPS/MBps limits)
before committing.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 6906e604-82b1-4ebc-a3c2-cf02a6745948

📥 Commits

Reviewing files that changed from the base of the PR and between 2ae0025 and 72cb5b6.

📒 Files selected for processing (2)

• test/e2e/azure-disk/ultrassd-manifest.yaml
• test/e2e/azure-disk/volumeattributesclass.yaml

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: radeore
Once this PR has been reviewed and has the lgtm label, please assign romanbednar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[radeore]

/retest-required

[openshift-ci]

@radeore: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hypershift-e2e-aks	6aaee72	link	false	/test hypershift-e2e-aks

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.