-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS#14939: Adding known issue for GitLab provider #99127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enterprise-4.20
Are you sure you want to change the base?
OSDOCS#14939: Adding known issue for GitLab provider #99127
Conversation
|
🤖 Tue Sep 30 16:17:42 - Prow CI generated the docs preview: |
|
@wewang58 @xingxingxia Here is the PR for the known issue. Please let me know how this sounds! |
|
|
||
|
|
||
|
|
||
| * When using GitLab as the external OIDC identity provider for direct authentication, clicking *Log out* from the {product-title} web console does not log you out of the console. (link:https://issues.redhat.com/browse/OCPBUGS-61649[OCPBUGS-61649]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bergerhoffer , Google has same logout issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, need add google has the same issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bergerhoffer for ADFS as the provider, there is a bug https://issues.redhat.com/browse/OCPBUGS-62142.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xingxingxia https://issues.redhat.com/browse/OCPBUGS-62142 I think the bug is critical, if we need to wait the bug to be fixed to add the ADFS in 4.20 docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wewang58 , I identified the root cause of https://issues.redhat.com/browse/OCPBUGS-62142 in its comment and updated the bug title with the root cause. It is ADFS refresh token too long. Then the console developer is looking into it. Anyway, I retried using the ADFS you installed and attempted 4 console logins:
1 I found 3 attempts failed but 1 succeeded. For each of the 3 failing logins, the "too long" message was printed. For the 1 success, the value wasn't considered too long, therefore the "too long" message wasn't printed. So users can have some chance of login success.
2 Even if in the failed console logins, clicking "Try again" can make the console login finally succeed as a workaround which you ever encountered too.
3 oc login works well
Based on this, maybe we can add ADFS in doc but with a known bug mentioned with the workaround noted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xingxingxia Yes, agree with you.
390d8e3 to
0c3dfbc
Compare
0c3dfbc to
22cd41c
Compare
|
@bergerhoffer: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@wewang58 @xingxingxia I added the known issue for ADFS, can you please take a look? I wasn't really clear on the exact workaround from the steps noted, so I put generically about reloading. But let me know if there's something more specific we should say here. |
|
@bergerhoffer I think it's enough, we already has the bug attached. |
|
/lgtm |
Version(s):
4.20
Issue:
https://issues.redhat.com/browse/OSDOCS-14939
Link to docs preview:
https://99127--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-20-release-notes.html#ocp-release-known-issues_release-notes
QE review:
Additional information: