Skip to content

test: add csharp integration test#1350

Merged
spacebear21 merged 2 commits intopayjoin:masterfrom
ValeraFinebits:test/add-csharp-integration-test
Feb 21, 2026
Merged

test: add csharp integration test#1350
spacebear21 merged 2 commits intopayjoin:masterfrom
ValeraFinebits:test/add-csharp-integration-test

Conversation

@ValeraFinebits
Copy link
Contributor

Add C# integration tests for Payjoin FFI, similar to other languages.

Pull Request Checklist

Please confirm the following before requesting review:

@ValeraFinebits ValeraFinebits marked this pull request as ready for review February 21, 2026 12:39
@arminsabouri arminsabouri requested a review from chavic February 21, 2026 14:13
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 22256960072

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.444%

Totals Coverage Status
Change from base Build 22242311720: 0.0%
Covered Lines: 10594
Relevant Lines: 12850

💛 - Coveralls

@benalleng benalleng self-requested a review February 21, 2026 14:28
@spacebear21 spacebear21 mentioned this pull request Feb 21, 2026
Copy link
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8fe975f, thanks for the prompt follow up!

I don't know C# at all so can't speak to the quality of the code but it seems reasonable to me and the CI confirms the newly added tests pass.

@spacebear21 spacebear21 merged commit 663fbdf into payjoin:master Feb 21, 2026
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants