Skip to content

Switch to upstream uniffi-bindgen-react-native#1367

Merged
spacebear21 merged 1 commit intopayjoin:masterfrom
spacebear21:update-ubrn-dependency
Feb 27, 2026
Merged

Switch to upstream uniffi-bindgen-react-native#1367
spacebear21 merged 1 commit intopayjoin:masterfrom
spacebear21:update-ubrn-dependency

Conversation

@spacebear21
Copy link
Collaborator

The upstream repo merged uniffi 0.30 support in jhugman/uniffi-bindgen-react-native#343 so we no longer need my custom fork.

  • Point dependency at upstream main (pinned to 93bed37)
  • Add uniffi_core 0.30 with wasm-unstable-single-threaded feature to wasm-manifest-patch.toml, since upstream's runtime crate hasn't enabled it yet and uniffi_core 0.30 requires it for wasm32 builds
  • Remove the home@=0.5.11 hack from generate_bindings.sh since upstream now pins it directly

Disclosure: co-authored by Claude Opus 4.6

Pull Request Checklist

Please confirm the following before requesting review:

The upstream repo (jhugman/uniffi-bindgen-react-native) merged
uniffi 0.30 support in PR payjoin#343, so we no longer need the fork.

- Point dependency at upstream main (pinned to 93bed37)
- Add uniffi_core 0.30 with wasm-unstable-single-threaded feature
  to wasm-manifest-patch.toml, since upstream's runtime crate
  hasn't enabled it yet and uniffi_core 0.30 requires it for
  wasm32 builds
@spacebear21 spacebear21 force-pushed the update-ubrn-dependency branch from 1e727a8 to eb90491 Compare February 27, 2026 03:05
@spacebear21 spacebear21 marked this pull request as ready for review February 27, 2026 04:53
@spacebear21 spacebear21 requested a review from chavic February 27, 2026 04:53
Copy link
Collaborator

@chavic chavic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@spacebear21 spacebear21 merged commit 8c17b8c into payjoin:master Feb 27, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants