Skip to content

Switch to upstream uniffi-bindgen-react-native #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spacebear21 merged 1 commit into from
Feb 27, 2026
Merged

Switch to upstream uniffi-bindgen-react-native #1367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions payjoin-ffi/javascript/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion payjoin-ffi/javascript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"prettier": "^3.6.2",
"tsx": "^4.20.6",
"typescript": "^5.9.3",
"uniffi-bindgen-react-native": "github:spacebear21/uniffi-bindgen-react-native#update-uniffi-0.30-wasm"
"uniffi-bindgen-react-native": "github:jhugman/uniffi-bindgen-react-native#93bed377c6e0b5cd7afd3fb7ee0d7211d5f294c5"
},
"repository": {
"type": "git",
Expand Down
10 changes: 9 additions & 1 deletion payjoin-ffi/javascript/wasm-manifest-patch.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,17 @@
# the library and CLI versions causes "unreachable" panics at runtime.
wasm-bindgen = "=0.2.108"

# uniffi_core 0.30 requires this feature for wasm32 builds to remove the
# Send bound on futures, which is not applicable in single-threaded WASM.
[dependencies.uniffi_core]
version = "0.30"
default-features = false
features = ["wasm-unstable-single-threaded"]

[patch.crates-io]
payjoin = { path = "../../../../payjoin" }
payjoin-directory = { path = "../../../../payjoin-directory" }
payjoin-test-utils = { path = "../../../../payjoin-test-utils" }
# This patch is required due to the hardcoded 0.29 dependency in uniffi-bindgen-react-native's Cargo.toml. Once they publish the 0.30 package we shouldn't need this anymore.
# uniffi-runtime-javascript is not yet published with uniffi_core 0.30 support.
# This path patch lets cargo resolve it from the installed npm package.
uniffi-runtime-javascript = { path = "../../node_modules/uniffi-bindgen-react-native/crates/uniffi-runtime-javascript" }
Loading