Open
Conversation
cfefe4a to
aa1591a
Compare
Collaborator
Pull Request Test Coverage Report for Build 22881193304Details
💛 - Coveralls |
aa1591a to
4f0c9fd
Compare
4f0c9fd to
4615291
Compare
2 tasks
82e2e67 to
fcef4ef
Compare
Replace the inline HTML stub in directory.rs with a proper landing page served from static/index.html. The page explains the mailroom concept (combined OHTTP relay + directory), links to documentation and the self-hosting guide, and includes a footer with version and commit hash. A build.rs emits the git commit hash at compile time so the footer stays current without manual updates.
caarloshenriq
left a comment
There was a problem hiding this comment.
Tested locally — ran the branch and the landing page loaded correctly. Great work!
One suggestion: it would be nice to add a test to ensure the placeholders are always replaced correctly before the HTML is served:
#[test]
fn landing_page_contains_version() {
let html = landing_page_html();
assert!(!html.contains("{{VERSION}}"));
assert!(!html.contains("{{COMMIT}}"));
}This guards against any future refactor accidentally leaving a raw {{VERSION}} or {{COMMIT}} in the response.
This guards against any future refactor accidentally leaving a raw
{{VERSION}} or {{COMMIT}} in the response.
Co-authored-by: carlos santos <rickhenriquetab@gmail.com>
fcef4ef to
635106c
Compare
Collaborator
Author
|
Great suggestion, thanks @caarloshenriq |
Contributor
|
you gotta pretty and modern mailroom @spacebear21 , it matches payjoin standards! tested locally and it's running perfectly, with all external links working well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1395
Authored by Claude Opus 4.6 and several attempts at fine-tuning the copy and design. Final result:
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.