Skip to content

Mailroom landing page#1401

Open
spacebear21 wants to merge 2 commits intopayjoin:masterfrom
spacebear21:mailroom-landing-page
Open

Mailroom landing page#1401
spacebear21 wants to merge 2 commits intopayjoin:masterfrom
spacebear21:mailroom-landing-page

Conversation

@spacebear21
Copy link
Collaborator

@spacebear21 spacebear21 commented Mar 9, 2026

Closes #1395

Authored by Claude Opus 4.6 and several attempts at fine-tuning the copy and design. Final result:

Screenshot 2026-03-09 at 13 11 34
Pull Request Checklist

Please confirm the following before requesting review:

@spacebear21 spacebear21 requested a review from zealsham March 9, 2026 17:12
@spacebear21 spacebear21 marked this pull request as draft March 9, 2026 17:12
@spacebear21 spacebear21 force-pushed the mailroom-landing-page branch from cfefe4a to aa1591a Compare March 9, 2026 17:16
@coveralls
Copy link
Collaborator

coveralls commented Mar 9, 2026

Pull Request Test Coverage Report for Build 22881193304

Details

  • 8 of 13 (61.54%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 83.844%

Changes Missing Coverage Covered Lines Changed/Added Lines %
payjoin-mailroom/src/directory.rs 8 13 61.54%
Files with Coverage Reduction New Missed Lines %
payjoin-mailroom/src/directory.rs 1 85.04%
Totals Coverage Status
Change from base Build 22866682076: 0.3%
Covered Lines: 10696
Relevant Lines: 12757

💛 - Coveralls

@spacebear21 spacebear21 force-pushed the mailroom-landing-page branch from aa1591a to 4f0c9fd Compare March 9, 2026 17:21
@spacebear21 spacebear21 marked this pull request as ready for review March 9, 2026 17:21
@spacebear21 spacebear21 force-pushed the mailroom-landing-page branch from 4f0c9fd to 4615291 Compare March 9, 2026 17:31
@spacebear21 spacebear21 force-pushed the mailroom-landing-page branch 2 times, most recently from 82e2e67 to fcef4ef Compare March 9, 2026 20:35
Replace the inline HTML stub in directory.rs with a proper
landing page served from static/index.html. The page explains
the mailroom concept (combined OHTTP relay + directory),
links to documentation and the self-hosting guide, and
includes a footer with version and commit hash.

A build.rs emits the git commit hash at compile time so the
footer stays current without manual updates.
Copy link

@caarloshenriq caarloshenriq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally — ran the branch and the landing page loaded correctly. Great work!

One suggestion: it would be nice to add a test to ensure the placeholders are always replaced correctly before the HTML is served:

    #[test]
    fn landing_page_contains_version() {
        let html = landing_page_html();
        assert!(!html.contains("{{VERSION}}"));
        assert!(!html.contains("{{COMMIT}}"));
    }

This guards against any future refactor accidentally leaving a raw {{VERSION}} or {{COMMIT}} in the response.

This guards against any future refactor accidentally leaving a raw
{{VERSION}} or {{COMMIT}} in the response.

Co-authored-by: carlos santos <rickhenriquetab@gmail.com>
@spacebear21 spacebear21 force-pushed the mailroom-landing-page branch from fcef4ef to 635106c Compare March 10, 2026 00:25
@spacebear21
Copy link
Collaborator Author

Great suggestion, thanks @caarloshenriq

@bc1cindy
Copy link
Contributor

you gotta pretty and modern mailroom @spacebear21 , it matches payjoin standards!

tested locally and it's running perfectly, with all external links working well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

payjoin-mailroom landing page improvements

4 participants