Ignore expanded entity nodes in source-backed sniffs#32
Conversation
fcb8c67 to
6974c7c
Compare
6974c7c to
27bcd61
Compare
|
Rebased and ready for review. |
jordikroon
left a comment
There was a problem hiding this comment.
Before:
FOUND 114632 violation(s) (114632 error(s), 0 warning(s)) in 10370 file(s).
After:
FOUND 50759 violation(s) (50759 error(s), 0 warning(s)) in 9993 file(s).
Given that #33 will introduce --wide, this behaviour is expected. But good to know.
| <testsuite name="unit"> | ||
| <directory>tests/Unit</directory> | ||
| </testsuite> | ||
| <testsuite name="integration"> |
There was a problem hiding this comment.
While it's debatable if they are unit tests. Could you merge them into tests/Unit instead?
There was a problem hiding this comment.
Sure, can follow your preference! Before I move them back: the end result in later branches is having Unit, Feature, and Integration. That is because there will be tests that run actual git commands for e2e testing. Given that, still all to Unit?
Ref: https://github.com/NickSdot/php__docbook-cs/tree/stack-09-performance/tests
There was a problem hiding this comment.
Ideally, yes. As it would also be more easy to distinguish between tests and non-tests (fixtures & Support).
c1980f3 to
4798a98
Compare
Ah, I should have mentioned this here. This is a change in behaviour that is not only related to |
Prevents sniffs from reporting violations for DOM nodes introduced by entity expansion rather than present in the inspected source file.
Depends on #29, #30, and #31.
This PR diff will shrink as preceding PRs are merged and this branch is rebased.