Skip to content

ext/standard: getimagesizefromstring() overflow.#22574

Closed
devnexen wants to merge 3 commits into
php:PHP-8.4from
devnexen:getimagesize_oflow
Closed

ext/standard: getimagesizefromstring() overflow.#22574
devnexen wants to merge 3 commits into
php:PHP-8.4from
devnexen:getimagesize_oflow

Conversation

@devnexen

@devnexen devnexen commented Jul 3, 2026

Copy link
Copy Markdown
Member

No description provided.

@devnexen
devnexen force-pushed the getimagesize_oflow branch from 8512e4c to 5e8f881 Compare July 3, 2026 12:39
@devnexen
devnexen marked this pull request as ready for review July 3, 2026 13:13
@devnexen
devnexen requested a review from bukka as a code owner July 3, 2026 13:13

@LamentXU123 LamentXU123 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reported this to through github through security section for like two month ago. Glad to see this is solved :)

Also, the getimagesize function also has the overflow issue. I will create a follow-up PR on this. Please review that if you have time ;)

@LamentXU123 LamentXU123 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh seems like this solve the getimagesize issue either. Good :)

Comment thread ext/standard/image.c Outdated
@LamentXU123

Copy link
Copy Markdown
Member

Nit: Also, are you interested in testing the getimagesize overflow either?

@devnexen

devnexen commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

that is your lucky day, the fix applies to both I ll add a new test case

@LamentXU123 LamentXU123 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@devnexen devnexen closed this in f08491b Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants