br: reword 'Base64-encoded storage' for accurate machine translation#23047
br: reword 'Base64-encoded storage' for accurate machine translation#23047yahonda wants to merge 2 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
missing-translation-status
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for log backup compaction in br-compact-log-backup.md and adds the "Row-based standard storage" metric to the built-in monitoring documentation in built-in-monitoring.md. The review feedback suggests style improvements to align with the documentation guidelines, specifically by removing unnecessary filler words to make instructions more direct and converting passive voice to active voice for better readability.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Three changes to br/br-compact-log-backup.md to improve machine translation quality to Japanese and avoid ambiguity: 1. 'matches the storage output' → 'should match the output' - 'storage output' is a confusing compound that MT renders literally - The actual output is the storage value/URI 2. 'With the Base64-encoded storage' → 'Once you have the Base64-encoded string from the previous step' - 'Base64-encoded storage' falsely implies the storage itself is encoded - What was encoded is the storage URI/string, not the storage - This mistranslation from Chinese '有了存储的 Base64' causes 'Base64エンコードストレージ' in Japanese 3. 'Base64-encoded storage string' → 'Base64-encoded string obtained in the previous step' - Same compound-noun ambiguity as above These changes ensure MT produces natural Japanese: ストレージ文字列 vs ストレージのBase64文字列, and avoids the nonsensical 'Base64エンコードストレージ'.
yahonda
force-pushed
the
fix-br-compact-log-backup
branch
from
931cd30 to
15545a5
Compare
…ckup and built-in-monitoring
[LGTM Timeline notifier]Timeline:
|
qiancai
added
type/enhancement
Synced from: pingcap/docs#23047 Target PR: pingcap#21714 AI Provider: azure Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
3 participants
What is changed, added or deleted? (Required)
This PR rewords ambiguous English phrases in
br/br-compact-log-backup.mdto produce more accurate machine translations to Japanese.Problem:
The original English text contains the phrase "Base64-encoded storage", which machine translators (and human translators) interpret as "storage itself being Base64-encoded". This leads to unnatural Japanese translations like "Base64エンコードストレージ" (Base64-encoded storage), which is confusing because what is actually encoded is the storage URI/string, not the storage.
The root cause traces back to the Chinese source phrase "有了存储的 Base64" (the Base64 of the storage / the storage's Base64), which was translated to English as "Base64-encoded storage" — reversing the possessive relationship and changing the meaning.
Changes:
These changes ensure machine translation produces natural Japanese: e.g., "Base64エンコードされた文字列" instead of the nonsensical "Base64エンコードストレージ".
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?