[Aikido] Fix 19 critical issues in form-data, @actions/github, @slack/web-api and 4 more#5
Closed
aikido-autofix[bot] wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
CVE-2025-25288 in @octokit/plugin-paginate-rest - low severity
@octokit/plugin-paginate-rest is the Octokit plugin to paginate REST API endpoint responses. For versions starting in 1.0.0 and prior to 11.4.1 of the npm package @octokit/plugin-paginate-rest, when calling octokit.paginate.iterator(), a specially crafted octokit instance—particularly with a malicious link parameter in the headers section of the request—can trigger a ReDoS attack. Version 11.4.1 contains a fix for the issue.
Details
Remediation Aikido suggests bumping this package to version 9.2.2 to resolve this issue
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
Author
|
Closed by Aikido: a new AutoFix has been created → #6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade dependencies to fix critical SSRF/proxy bypass and RCE vulnerabilities in Axios, HTTP Parameter Pollution in form-data, and prototype pollution attacks across multiple packages. This update includes breaking changes that require manual migration.
Breaking Change: Removed functionality that removed the Content-Type request header when passing FormData (0.27.0)
Where your code is affected:
dist/index.js- The Slack WebClient implementation that uses FormData for multipart uploadsImpact: In axios 0.19.2, when FormData was passed as request data, axios automatically deleted the
Content-Typeheader to let the browser/environment set it correctly. In axios 0.27.0+, this automatic deletion was removed. The code indist/index.jsmanually creates FormData instances and copies headers fromform.getHeaders()into the request headers. However, the WebClient also explicitly deletes the default POST Content-Type header (delete this.axios.defaults.headers.post['Content-Type']). With the new axios version, if a Content-Type header is already set in the defaults or request config, it may not be properly overridden by the FormData boundary header, potentially causing multipart upload failures.Remediation: Ensure that when FormData is used in
serializeApiCallOptions, any existing Content-Type header is explicitly deleted from the request headers before copying FormData headers, or verify that the customtransformRequestfunction properly handles Content-Type for FormData requests.Breaking Change: Refactored error handling implementing AxiosError as a constructor (0.27.0)
Where your code is affected:
dist/index.js- Error handling in the WebClient'smakeRequestand related methodsImpact: The error structure and properties of axios errors have changed. Code that catches and inspects axios errors may need to be updated to work with the new AxiosError constructor pattern. This affects error handling throughout the WebClient implementation.
Remediation: Review all axios error handling code to ensure compatibility with the new AxiosError constructor pattern, checking that error properties like
response,request, andconfigare accessed correctly.All breaking changes by upgrading axios from version 0.19.2 to 0.31.1 (CHANGELOG)
✅ 19 CVEs resolved by this upgrade, including 2 critical 🚨 CVEs
This PR will resolve the following CVEs:
allowAbsoluteUrlsnot being set tofalseby default inbuildFullPath(), allowing attackers to bypass URL restrictions and process unintended URLs.formDataToJSONfunction allows attackers to manipulate object properties. Additionally, a ReDoS vulnerability incombineURLscan cause denial of service through malicious input.This issue affects form-data: < 2.5.4, 3.0.0 - 3.0.3, 4.0.0 - 4.0.3.