[Aikido] Fix 19 critical issues in form-data, @actions/github, @slack/web-api and 4 more#6
Closed
aikido-autofix[bot] wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
CVE-2025-25288 in @octokit/plugin-paginate-rest - low severity
@octokit/plugin-paginate-rest is the Octokit plugin to paginate REST API endpoint responses. For versions starting in 1.0.0 and prior to 11.4.1 of the npm package @octokit/plugin-paginate-rest, when calling octokit.paginate.iterator(), a specially crafted octokit instance—particularly with a malicious link parameter in the headers section of the request—can trigger a ReDoS attack. Version 11.4.1 contains a fix for the issue.
Details
Remediation Aikido suggests bumping this package to version 9.2.2 to resolve this issue
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
Author
|
Closed by Aikido: a new AutoFix has been created → #7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade dependencies to fix critical SSRF/proxy bypass and RCE vulnerabilities in Axios, HTTP Parameter Pollution in form-data, and prototype pollution attacks across multiple packages.
✅ The axios upgrade from 0.19.2 to 0.31.1 and form-data upgrade from 2.5.1 to 2.5.4 do not introduce breaking changes that affect this codebase.
Analysis:
This codebase does not directly use axios or form-data. These packages are transitive dependencies through
@slack/web-apiv5.15.0, which is bundled indist/index.js.The code in
@slack/web-apithat uses these packages:Creates FormData instances and uses
form.append()andform.getHeaders()methods (dist/index.js)Deletes the
Content-Typeheader from axios defaults to let the serializer set it appropriatelyUses axios for HTTP requests with error handling that checks
error.requestpropertyBreaking changes reviewed:
axios (0.27.0): Removed functionality that removed Content-Type header when passing FormData - The
@slack/web-apicode explicitly deletesContent-Typefrom axios defaults and manages it through its ownserializeApiCallOptionsmethod, so this change doesn't affect it.axios (0.27.0): Refactored error handling implementing AxiosError as a constructor - The code only checks for
error.requestproperty existence, which remains available in the new AxiosError implementation.form-data (2.5.4):
setBoundary()validation - The codebase never callssetBoundary()method; it only usesappend()andgetHeaders().axios type changes (0.23.0, 0.24.0): TypeScript type changes - This is a JavaScript project without TypeScript source files, so type changes don't affect it.
All other changelog entries are bug fixes, new features, or internal improvements that don't break existing functionality.
All breaking changes by upgrading axios from version 0.19.2 to 0.31.1 (CHANGELOG)
✅ 19 CVEs resolved by this upgrade, including 2 critical 🚨 CVEs
This PR will resolve the following CVEs:
allowAbsoluteUrlsnot being set tofalseby default inbuildFullPath(), allowing attackers to bypass URL restrictions and process unintended URLs.formDataToJSONfunction allows attackers to manipulate object properties. Additionally, a ReDoS vulnerability incombineURLscan cause denial of service through malicious input.This issue affects form-data: < 2.5.4, 3.0.0 - 3.0.3, 4.0.0 - 4.0.3.