Skip to content

Fix script bundle creation and improve PEM/Kelvin heap dump collection for large clusters#2247

Merged
ddelnano merged 1 commit intopixie-io:mainfrom
ddelnano:ddelnano/fix-script-bundle-improve-heap-dump-scripts
Jul 25, 2025
Merged

Fix script bundle creation and improve PEM/Kelvin heap dump collection for large clusters#2247
ddelnano merged 1 commit intopixie-io:mainfrom
ddelnano:ddelnano/fix-script-bundle-improve-heap-dump-scripts

Conversation

@ddelnano
Copy link
Member

@ddelnano ddelnano commented Jul 24, 2025

Summary: Fix script bundle creation and improve PEM/Kelvin heap dump collection for large clusters

The src/pxl_scripts/px/collect_heap_dumps.pxl was added at the root of a top level script directory. Since this script is largely used adhoc, this went unnoticed until I worked on #2245 and #2246. This moves the script into a proper directory structure and updates it to accommodate very large clusters (see relevant issue for more details).

Relevant Issues: #2245

Type of change: /kind bug

Test Plan: Verified pxl script runs in the UI and that bundle creation works again

# Fails on main

(main) $ make bundle-oss.json
px create-bundle --search_path /home/ddelnano/code/pixie-extra/src/pxl_scripts --base bpftrace --base px --base pxbeta --base sotw -o /home/ddelnano/code/pixie-extra/src/pxl_scripts/bundle-oss.json
Pixie CLI
FATA[0000] Failed to create bundle                       error="open /home/ddelnano/code/pixie-extra/src/pxl_scripts/px/manifest.yaml: no such file or directory"
make: *** [Makefile:28: bundle-oss.json] Error 1

# Succeeds with this change

(ddelnano/fix-script-bundle-improve-heap-dump-scripts) $ make bundle-oss.json
px create-bundle --search_path /home/ddelnano/code/pixie-extra/src/pxl_scripts --base bpftrace --base px --base pxbeta --base sotw -o /home/ddelnano/code/pixie-extra/src/pxl_scripts/bundle-oss.json
Pixie CLI

@ddelnano ddelnano requested a review from a team as a code owner July 24, 2025 21:34
@ddelnano ddelnano force-pushed the ddelnano/fix-script-bundle-improve-heap-dump-scripts branch from 67f1f12 to 4261be2 Compare July 24, 2025 21:39
@ddelnano
Copy link
Member Author

The linting issue will be fixed when #1955 is merged.

…n for large clusters

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
(cherry picked from commit f1d8034)
@ddelnano ddelnano force-pushed the ddelnano/fix-script-bundle-improve-heap-dump-scripts branch from 4261be2 to eb35471 Compare July 25, 2025 13:32
@ddelnano ddelnano merged commit 87cbf8a into pixie-io:main Jul 25, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments