Notification, Gradle, Intent and more refactoring & updates#184
Open
eakteam wants to merge 6 commits intoppareit:masterfrom
Open
Notification, Gradle, Intent and more refactoring & updates#184eakteam wants to merge 6 commits intoppareit:masterfrom
eakteam wants to merge 6 commits intoppareit:masterfrom
Conversation
eakteam
changed the title
It is not needed and sometimes annoying too...
eakteam
changed the title
When the app first start writing external storage is null and most of the users start the service without setting it up. This results on starting the service and after connecting via FTP client nothing is shown on the file tree. So better to notify them when using Android 11+
eakteam
changed the title
Refactor to use Android native log instead of cat library to keep the app as pure as possible.
ppareit
reviewed
Apr 13, 2023
Owner
ppareit
left a comment
ppareit
left a comment
There was a problem hiding this comment.
I understand you. But I'm so used to Cat. Is it really a big problem?
If we make this change, we need to use a static String TAG for each class. I also don't like that.
Owner
There was a problem hiding this comment.
This is correct.
Wish I would have seen this earlier.
The onCreate has just been changed in a little different way. Instead of asking the user to press the hidden option, the app now opens the Scoped storage chooser itself. Does this work for you?
There was a problem hiding this comment.
You can actually remove the check too if wanted. The intent of use was its seen in a bad state but technically could just leave that for the user to deal without the extra helpful smoothing out of it :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent.