You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds vitest-fail-on-console to packages/react so tests fail when unexpected console.error or console.warn calls occur during CI. This catches React warnings and component bugs early.
Changes
Setup:
Install vitest-fail-on-console dev dependency
Configure in packages/react/config/vitest/browser/setup.ts (CI only)
Bug fixes discovered by new checks:
CircleBadge: Destructure inline, size, variant before spreading to DOM
Deprecated ActionList Group: Destructure groupId, showItemDividers before spreading
UnderlineNav: Filter leadingVisual/icon props from ActionList.LinkItem spread
Test updates:
implementsClassName utility now suppresses console during className-only tests
Tests expecting errors now mock console.error/console.warn before render
Tests with async act warnings use unmount() before mockRestore() to prevent late callbacks
Changelog
New
vitest-fail-on-console integration for CI test runs
Changed
CircleBadge no longer passes inline, size, variant props to DOM elements
ActionList.Group (deprecated) no longer passes groupId, showItemDividers to DOM elements
UnderlineNav no longer passes leadingVisual, icon through to DOM via overflow menu
Removed
N/A
Rollout strategy
Patch release
Minor release
Major release; if selected, include a written rollout or migration plan
None; if selected, include a brief description as to why
Testing & Reviewing
Run CI=true npx vitest to verify tests pass with fail-on-console enabled.
Add vitest-fail-on-console to the project so that tests fail when a console.* call is triggered during CI. This should be added specifically to the setup for packages/react. Fix any failing tests and verify by running npx vitest
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
- Install vitest-fail-on-console in packages/react
- Configure it in browser setup to run only in CI
- Update implementsClassName utility to suppress console calls
- Fix CircleBadge to not pass inline/size/variant to DOM
- Fix deprecated ActionList Group to not pass groupId to DOM
- Fix tests that expect errors to mock console.error first
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
- Add console.error mocks for tests expecting error throws
- Fix UnderlineNav to not pass leadingVisual/icon props to DOM
- Add mocks for act warnings in TreeView, Breadcrumbs, Pagination, Tabs tests
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
- Add unmount() calls before spy.mockRestore() to prevent late async callbacks
- Fixes TreeView and Pagination tests that had MutationObserver callbacks firing after cleanup
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
CopilotAI
changed the title
[WIP] Add vitest-fail-on-console to react package setup
Add vitest-fail-on-console to fail tests on console calls in CI
Dec 29, 2025
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
the
integration-tests: recommended
Adds
vitest-fail-on-consoleto packages/react so tests fail when unexpectedconsole.errororconsole.warncalls occur during CI. This catches React warnings and component bugs early.Changes
Setup:
vitest-fail-on-consoledev dependencypackages/react/config/vitest/browser/setup.ts(CI only)Bug fixes discovered by new checks:
CircleBadge: Destructureinline,size,variantbefore spreading to DOMDeprecated ActionList Group: DestructuregroupId,showItemDividersbefore spreadingUnderlineNav: FilterleadingVisual/iconprops from ActionList.LinkItem spreadTest updates:
implementsClassNameutility now suppresses console during className-only testsconsole.error/console.warnbefore renderunmount()beforemockRestore()to prevent late callbacksChangelog
New
vitest-fail-on-consoleintegration for CI test runsChanged
CircleBadgeno longer passesinline,size,variantprops to DOM elementsActionList.Group(deprecated) no longer passesgroupId,showItemDividersto DOM elementsUnderlineNavno longer passesleadingVisual,iconthrough to DOM via overflow menuRemoved
N/A
Rollout strategy
Testing & Reviewing
Run
CI=true npx vitestto verify tests pass with fail-on-console enabled.Merge checklist
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.