Skip to content

fix(promote): reject non-decimal numeric limits#805

Open
aiirvizionz wants to merge 1 commit into
profullstack:masterfrom
aiirvizionz:clientkit/promote-decimal-limits
Open

fix(promote): reject non-decimal numeric limits#805
aiirvizionz wants to merge 1 commit into
profullstack:masterfrom
aiirvizionz:clientkit/promote-decimal-limits

Conversation

@aiirvizionz

Copy link
Copy Markdown
Contributor

Summary

  • require plain decimal input for promote integer limit parsers
  • reject scientific and hexadecimal numeric strings for max/delay style options
  • add direct regression coverage for promote numeric parsers

Tests

  • node_modules/.bin/vitest.CMD run packages/cli/src/commands/promote.test.ts
  • node_modules/.bin/tsc.CMD -p packages/cli/tsconfig.json --noEmit
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant