Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions packages/cli/src/commands/promote.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import { describe, expect, it } from 'vitest';
import { parseNonNegativeInteger, parsePositiveInteger } from './promote.js';

describe('promote numeric option parsers', () => {
it('accepts decimal positive integers', () => {
expect(parsePositiveInteger('25')).toBe(25);
});

it.each(['0', '-1', '1.5', '1e2', '0x10', 'Infinity', 'NaN', 'abc'])(
'rejects invalid positive integer %s',
(value) => {
expect(() => parsePositiveInteger(value)).toThrow('positive integer');
},
);

it('accepts decimal non-negative integers', () => {
expect(parseNonNegativeInteger('0')).toBe(0);
expect(parseNonNegativeInteger('2000')).toBe(2000);
});

it.each(['-1', '1.5', '1e2', '0x10', 'Infinity', 'NaN', 'abc'])(
'rejects invalid non-negative integer %s',
(value) => {
expect(() => parseNonNegativeInteger(value)).toThrow('zero or a positive integer');
},
);
});
6 changes: 4 additions & 2 deletions packages/cli/src/commands/promote.ts
Original file line number Diff line number Diff line change
Expand Up @@ -866,13 +866,15 @@ function stripAiPrefix(p: string): string {
return p.replace(/^ai-/, '').toLowerCase();
}

function parsePositiveInteger(value: string): number {
export function parsePositiveInteger(value: string): number {
if (!/^\d+$/.test(value)) throw new InvalidArgumentError('must be a positive integer');
const parsed = Number(value);
if (!Number.isInteger(parsed) || parsed < 1) throw new InvalidArgumentError('must be a positive integer');
return parsed;
}

function parseNonNegativeInteger(value: string): number {
export function parseNonNegativeInteger(value: string): number {
if (!/^\d+$/.test(value)) throw new InvalidArgumentError('must be zero or a positive integer');
const parsed = Number(value);
if (!Number.isInteger(parsed) || parsed < 0) throw new InvalidArgumentError('must be zero or a positive integer');
return parsed;
Expand Down
Loading