Adding KIND provider for the prombench#390
Merged
geekodour merged 21 commits intoprometheus:masterfrom Sep 2, 2020
Merged
Conversation
Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
imrajdas
changed the title
Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
Contributor
Author
|
cc @geekodour This PR is ready for review |
Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
Signed-off-by: Raj Babu Das <raj.das@mayadata.io>
Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
Contributor
Author
|
@geekodour circleCI has been passed |
1 task
Contributor
Author
1 task
geekodour
reviewed
Jul 19, 2020
imrajdas
force-pushed
the
kind-provider
branch
2 times, most recently
from
5292317 to
de43323
Compare
Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
Contributor
|
The tests seem to be failing aswell 🤔 |
Contributor
Author
Doc format failure |
Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
Contributor
Author
|
@geekodour , I made the changes as per your suggestion and build is also passed. PTAL |
geekodour
reviewed
Aug 9, 2020
Contributor
geekodour
left a comment
geekodour
left a comment
There was a problem hiding this comment.
Few more changes and suggestions about logging and validation.
geekodour
reviewed
Aug 12, 2020
Contributor
geekodour
left a comment
geekodour
left a comment
There was a problem hiding this comment.
few more suggestions and improvements :)
Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
imrajdas
force-pushed
the
kind-provider
branch
from
c9bcf41 to
a951969
Compare
Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
geekodour
reviewed
Aug 21, 2020
imrajdas
changed the title
imrajdas
force-pushed
the
kind-provider
branch
from
b9c8b1a to
1940fb7
Compare
Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
imrajdas
force-pushed
the
kind-provider
branch
from
1940fb7 to
3a6eea3
Compare
Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
Contributor
|
I remember @gouthamve requesting local running of prombench, It runs locally now with this PR. :) but still need improvements, also have to figure out running prombench from local images thing. Do you have any other suggestions/requests for local running of prombench? But this should make adding and testing new components in the test-infra easier ✨ |
Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
Contributor
|
🎉 merged. thanks for all your work! :) Will add info on E2E test-infra tests and supporting local images in another PR. |
kushalShukla-web
pushed a commit
to kushalShukla-web/test-infra
that referenced
this pull request
Feb 8, 2025
This PR adds support of running test-infra components locally using the KIND provider. KIND specific commands are added to the infra CLI. When running locally, we don't have lot of CPU and memory resources. LOADGEN_SCALE_UP_REPLICAS deployment variable was added which makes sure that when run locally we're only scale to 2 fake-webservers. Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Issue: #333