Removing unused service-account secret from 1b_secret#412
Merged
geekodour merged 1 commit intoprometheus:masterfrom Jul 30, 2020
Merged
Removing unused service-account secret from 1b_secret#412geekodour merged 1 commit intoprometheus:masterfrom
geekodour merged 1 commit intoprometheus:masterfrom
Conversation
Contributor
Author
|
cc @geekodour |
Contributor
|
Could we also remove this? Line 4 in 2c519dd |
Contributor
Author
|
AUTH_FILE is used by other make steps in Makefile. If we remove this other commands will not work |
Contributor
|
We don't need the default value anymore, since we're providing it in our command runs. It was used for this: It should work, can you check? |
Contributor
Author
Okay, Will remove it. |
Contributor
|
could you remove this line from the readme aswell? :) as it's no longer used. |
Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
Contributor
Author
Removed |
Contributor
|
@rajdas98 please get rid of this line aswell :) |
kushalShukla-web
pushed a commit
to kushalShukla-web/test-infra
that referenced
this pull request
Feb 8, 2025
Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Raj Babu Das mail.rajdas@gmail.com
To support the PR Adding KIND provider for the prombench #390, we need to remove this unused service-account secret from 1b_secret
Tested in GKE https://gist.github.com/rajdas98/c811dd665398bbf7ca00dabfd19267e8