Converting ingress service type as deployment var and adding a infra CLI command to show deployment vars

[imrajdas]

Motivation:

• As KIND doesn't support Loadbalance type service, That's why it converts ingress service type as deployment var (PROVIDER_SERVICE) and assigning that deployment var in NewGKEClient function of gke.go

Changes:

• Adding NGINX_SERVICE variable for the load balancer service type
• Adding gke info deploymentvars command to show all default deployment variables.

Signed-off-by: Raj Babu Das mail.rajdas@gmail.com

[imrajdas]

cc @geekodour

[imrajdas]

Logs-
log.txt

[geekodour]

What I was suggesting was something like

c.DeploymentVars["PROVIDER_SERVICE"] = "GKE" 

and use something like

{{ if (eq .PROVIDER_SERVICE "GKE") }}

in the manifest file, but the approach in this PR actually looks better i think :) . I've commented some ways this can be improved.

cc @krasi-georgiev @nevill

[geekodour]

Suggested change

	c.DeploymentVars["PROVIDER_SERVICE"] = "LoadBalancer"
	c.DeploymentVars["NGINX_SERVICE_TYPE"] = "LoadBalancer"

In the provider specific docs, we could just add a section about what are the deployment variables that are automatically passed for this specific provider.

It'll be good if we could have these deployment variables overridable when uses passes the same using the -v flag. Maybe also have a provider specific flag to list out all the set deployment variables. (This way we won't have to update readme manually and we could just use embedmd #353)

What I think will be good is to have a default DeploymentVars and have it set to the default value, like for eg. in this example only nginx controller k8s service type needs to be changed when running in KIND (to CLusterIP).

But for EKS and GKE, the type LoadBalancer works, so we could have some defaults and only modify them when creating the provider that needs the change(in our case KIND)

[geekodour]

@rajdas98 Also ingress in kind uses
https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/static/provider/kind/deploy.yaml

And GKE currently uses
https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/static/provider/cloud/deploy.yaml

Difference being :

λ diff gke_deploy.yml kind_deply.yml 
287,288c287
<   type: LoadBalancer
<   externalTrafficPolicy: Local
---
>   type: NodePort
322a322,325
>   strategy:
>     rollingUpdate:
>       maxUnavailable: 1
>     type: RollingUpdate
343d345
<             - --publish-service=ingress-nginx/ingress-nginx-controller
349a352
>             - --publish-status-address=localhost
390a394
>               hostPort: 80
393a398
>               hostPort: 443
404a410,415
>       nodeSelector:
>         ingress-ready: 'true'
>       tolerations:
>         - effect: NoSchedule
>           key: node-role.kubernetes.io/master
>           operator: Equal
406c417
<       terminationGracePeriodSeconds: 300
---
>       terminationGracePeriodSeconds: 0

So, is just changing the service type enough?

[geekodour]

So as far as i can see there should be three levels to this:

• default deployment vars (which get set provider agnostic)

• provider deployment vars which has a different value than default deployment var Eg. (Loadbalancer in gke and Nodeport in kind) Here the default could be Loadbalancer as it's used by both gke and eks and we need to replace it only for KIND

• the normal deployment vars at use, this should be able to override both default and provider specific deployment vars.

[geekodour]

Nice work! 👍 Thanks!

Some suggestions and improvements.

[geekodour]

Some questions and suggestions. :)

[geekodour]

Some questions and suggestions :)

I think once this is merged, we don't have any other blockers for local?

[geekodour]

Everything looks good 🥳 just small nits.

Will merge after changes are resolved :)