Fix gap detection documentation and default times - #263
Open
DPDmancul wants to merge 2 commits into
Open
Conversation
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #243
This is a step further of #262. The previous PR only fixes the documentation, without changing any behavior.
This PR instead fixes also the default gap detection times, setting them to the intended default values. This because otherwise the default gap detection time would be up to 500 μs, which is too low.
This does not multiply by 1000 custom gap detection times inserted by the users, so it is not a breaking change.
Please merge the variant is beast suited: I suggest for #263, but if you think changing the effective defaults is too risky, then go for #262.