Changes to make querydsl-elasticsearch work with latest elasticsearch#15
Changes to make querydsl-elasticsearch work with latest elasticsearch#15gkathire wants to merge 2 commits intoquerydsl:masterfrom gkathire:master
Conversation
- Fixes to make querydsl-elasticsearch to work with the latest elasticsearch 2.x - Added the String Contains Ignorecase criteria support
|
Hello, Changes to upgrade the elasticsearch version to 2.x will break backward compatibility, we need to keep the projet running on elasticsearch 1.x version for groupId/artificatId.
@timowest : what do you think ? Is it better to copy the project and made proposed changes ? For the new criteria support, it's ok for me. Regards |
|
Sure, I can create a new pull request for the new criteria support. Since there are only 3 files in the project, i think we can make a copy of it and create a new querydsl-elasticsearch2 project. In that case we will have more freedom to make changes to the project with the new es2 specific changes without confined to the es1.x api. Let me know what to do and I can create a new pull request based on the suggestion. |
|
I agree that a querydsl-elasticsearch2 project would be better |
|
Regarding to spring-projects/spring-data-elasticsearch#134, can we merge this pull request ? |
|
If you use the patch from #16 , you dont have to upgrade the elastic search. It contains support for elasticsearch-2 support as a new library. |
|
Closing in favor of #19 |
This change contains
Except for the Package verification test case , other test cases passed.
Let me know if you need any other changes to this fix.