Skip to content

DATAES-219 Developments for querydsl-elasticsearch integration.#134

Closed
kevinleturc wants to merge 1 commit intospring-projects:masterfrom
kevinleturc:feature-querydsl-integration
Closed

DATAES-219 Developments for querydsl-elasticsearch integration.#134
kevinleturc wants to merge 1 commit intospring-projects:masterfrom
kevinleturc:feature-querydsl-integration

Conversation

@kevinleturc
Copy link
Contributor

No description provided.

@kevinleturc kevinleturc force-pushed the feature-querydsl-integration branch from 5299781 to 0102bbd Compare February 1, 2016 22:02
@martin-g
Copy link

This PR has very high quality. I'm not sure why there is no feedback on it for almost 50 days now.
Good work, @kevinleturc !

@odrotbohm
Copy link
Member

Ping @mohsinh.

@kevinleturc
Copy link
Contributor Author

Hello,
Thanks @martin-g, just try to add good features I used with spring-data-mongodb.

Currently the pull request can not be merged due to upgrade to elasticsearch 2.x. @gkathire proposed a pull request to https://github.com/querydsql/querydsl-contrib for elasticsearch 2.x. I'll ask @timowest to merge it in order to change this PR.

@mohsinh, is it something we can discuss to merge ?
@olivergierke, as querydsl version is not aligned with querydsl-contrib, do we need an additional property for querydsl-contrib ? What about querydsl-apt version which is shared across two projects ? Maybe we can discuss it with @timowest ?

PS: The querydsl-contrib PR : querydsl/querydsl-contrib#15

@akonczak
Copy link
Contributor

For more info please check - https://jira.spring.io/browse/DATAES-219

@akonczak
Copy link
Contributor

We are still waiting for QueryDSL team for release of 'querydsl-contrib' project.

@bryancuster
Copy link

querydsl/querydsl-contrib#19 looks to have been merged, is there anything else blocking the support?

@kevinleturc
Copy link
Contributor Author

There is, querydsl/querydsl-contrib#19 brought support for ES 2.x. And now spring-data-elasticsearch support ES 5.x.
This PR could be a candidate for 2.1.x branch if it's possible, but we'll miss support on latest version.

@ft0907
Copy link

ft0907 commented Jul 3, 2018

@olivergierke @kevinleturc
When is the es5.x version available to support querydsl ?
Or have no follow-up information to support?

@sothawo
Copy link
Collaborator

sothawo commented Aug 10, 2019

closing this PR, as the latest supported version of Elasticsearch in Querydsl is 2.2.2 whic is not supported by Spring Data Elasticsearch anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants