RDKEAPPRT-879,324 - Remove CEC Plugin Activation/Deactivation from CEC Control Setting by SudarsananComcast · Pull Request #224 · rdkcentral/rdke-refui

SudarsananComcast · 2026-07-13T09:05:51Z

No description provided.

Copilot

Pull request overview

This PR aims to remove direct Thunder plugin activation/deactivation side effects from the “CEC Control” setting, shifting the control flow toward toggling the CEC enabled state instead of activating/deactivating the org.rdk.HdmiCecSource plugin.

Changes:

Commented out CEC plugin activation logic in _init().
Refactored toggleCEC() to compute a target enabled state and call setEnabled(...), then update the toggle icon accordingly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+               // get the current state and toggle it
+               const newEnabledState = !res.enabled
+            this.cecApi.setEnabled({ enabled: newEnabledState })
+                .then(() => {


Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

+                const newEnabledState = !(res && res.enabled)
+                this.cecApi.setEnabled(newEnabledState)
+                    .then(() => {
+                        const imageSrc = newEnabledState
+                            ? 'images/settings/ToggleOnOrange.png'
+                            : 'images/settings/ToggleOffWhite.png'
+                        this.tag('CECControl.Button').src = Utils.asset(imageSrc)
+                    })


Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

+                this.cecApi.setEnabled(newEnabledState)
+                    .then(() => {
+                    // Update UI based on new state
+                        const imageSrc = newEnabledState
+                            ? 'images/settings/ToggleOnOrange.png'
+                            : 'images/settings/ToggleOffWhite.png'
+                        this.tag('CECControl.Button').src = Utils.asset(imageSrc)
+                        if (newEnabledState) {
+                            this.performOTPAction()
+                        }
+                    })


into rdkeApprt-879

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

+                this.cecApi.setEnabled(newEnabledState)
+                    .then(() => {
+                    // Update UI based on new state
+                        const imageSrc = newEnabledState
+                            ? 'images/settings/ToggleOnOrange.png'
+                            : 'images/settings/ToggleOffWhite.png'
+                        this.tag('CECControl.Button').src = Utils.asset(imageSrc)
+                        if (newEnabledState) {
+                            this.performOTPAction()
+                        }
+                    })


+                const isEnabled = !!(res && res.enabled)
+                  console.log(`CEC initial status: ${isEnabled}`)
+


Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

+                // get the current state and toggle it.
+                const newEnabledState = !(res && res.enabled)
+                this.cecApi.setEnabled(newEnabledState)
+                    .then(() => {
+                    // Update UI based on new state
+                        const imageSrc = newEnabledState
+                            ? 'images/settings/ToggleOnOrange.png'
+                            : 'images/settings/ToggleOffWhite.png'
+                        this.tag('CECControl.Button').src = Utils.asset(imageSrc)
+                        if (newEnabledState) {
+                            this.performOTPAction()
+                        }
+                    })


+                const isEnabled = !!(res && res.enabled)
+                  console.log(`CEC initial status: ${isEnabled}`)


arun-madhavan-013

CEC plugin activation is needed. UI is common for both Source & Sink devices.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js:248

toggleCEC() still calls cecApi.activate() and unconditionally updates UI/storage in .then(() => ...) even when setEnabled() fails (it can resolve { success: false } on error). This conflicts with the PR goal of removing plugin activation/deactivation from the setting (the plugin is already activated in App.js) and can desync the toggle UI from the real CEC state. Prefer calling setEnabled(newEnabledState) directly and gate UI/storage updates on a successful result.

                const newEnabledState = !(res && res.enabled)
                // if newEnabledState is true,then first activate CEC and then setEnabled to true, 
                // else just setEnabled to false
                const togglePromise = newEnabledState
                    ? this.cecApi.activate().then(() => this.cecApi.setEnabled(true))

accelerator-home-ui/src/overlays/OtherSettings/AdvancedSettingsScreenOverlay.js:233

toggleCEC() still calls cecApi.activate() and unconditionally updates UI/storage in .then(() => ...) even when setEnabled() fails (it can resolve { success: false } on error). This conflicts with the PR goal of removing plugin activation/deactivation from the setting (the plugin is already activated in App.js) and can desync the toggle UI from the real CEC state. Prefer calling setEnabled(newEnabledState) directly and gate UI/storage updates on a successful result.

                const newEnabledState = !(res && res.enabled)
                // if newEnabledState is true,then first activate CEC and then setEnabled to true, 
                // else just setEnabled to false
                const togglePromise = newEnabledState
                    ? this.cecApi.activate().then(() => this.cecApi.setEnabled(true))

SudarsananComcast · 2026-07-21T10:42:26Z

Hi @arun-madhavan-013 CEC is activated in app.js file. just removed where the activate function call is not required.

removed activate for CEC api

8d222f2

Copilot AI review requested due to automatic review settings July 13, 2026 09:05

Copilot started reviewing on behalf of SudarsananComcast July 13, 2026 09:06 View session

SudarsananComcast requested review from suryag23 and yashaswini-rk July 13, 2026 09:06

Copilot AI reviewed Jul 13, 2026

View reviewed changes

added condition for CEC toggle button

8f591a0

Copilot AI review requested due to automatic review settings July 13, 2026 09:38

Copilot started reviewing on behalf of SudarsananComcast July 13, 2026 09:38 View session

Copilot AI reviewed Jul 13, 2026

View reviewed changes

added perform otp in initState

7d6e823

Copilot AI review requested due to automatic review settings July 13, 2026 10:18

changed toggle spelling

99137f8

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot started reviewing on behalf of SudarsananComcast July 13, 2026 10:20 View session

Copilot AI reviewed Jul 13, 2026

View reviewed changes

Comment thread accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js Outdated

Comment thread accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js

Copilot AI review requested due to automatic review settings July 13, 2026 10:20

Copilot started reviewing on behalf of SudarsananComcast July 13, 2026 10:21 View session

Copilot AI reviewed Jul 13, 2026

View reviewed changes

Kumar added 2 commits July 14, 2026 15:38

added logs

68fb27a

Merge branch 'rdkeApprt-879' of https://github.com/rdkcentral/rdke-refui

9ff3638

into rdkeApprt-879

Copilot AI review requested due to automatic review settings July 14, 2026 10:10

Copilot started reviewing on behalf of SudarsananComcast July 14, 2026 10:12 View session

Copilot AI reviewed Jul 14, 2026

View reviewed changes

Comment thread accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js

Comment thread accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js Outdated

sync with develop

86fb68a

Copilot AI review requested due to automatic review settings July 15, 2026 11:49

Copilot started reviewing on behalf of SudarsananComcast July 15, 2026 11:50 View session

Copilot AI reviewed Jul 15, 2026

View reviewed changes

Comment thread accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js Outdated

Comment thread accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js Outdated

SudarsananComcast added 2 commits July 15, 2026 17:22

version changed

8fedff3

version changed

bfb6357

Copilot AI review requested due to automatic review settings July 15, 2026 11:53

Copilot started reviewing on behalf of SudarsananComcast July 15, 2026 11:53 View session

Copilot AI reviewed Jul 15, 2026

View reviewed changes

removed activated for CEC Api

38c4be4

Copilot AI review requested due to automatic review settings July 17, 2026 11:03

Copilot started reviewing on behalf of SudarsananComcast July 17, 2026 11:03 View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

arun-madhavan-013 requested changes Jul 20, 2026

View reviewed changes

used storage to store the CEC Status

0af4a10

Copilot AI review requested due to automatic review settings July 21, 2026 09:49

Copilot started reviewing on behalf of SudarsananComcast July 21, 2026 09:49 View session

Copilot AI reviewed Jul 21, 2026

View reviewed changes

SudarsananComcast requested a review from arun-madhavan-013 July 22, 2026 08:11

SudarsananComcast changed the title ~~Remove CEC Plugin Activation/Deactivation from CEC Control Setting [RDKEAPPRT-879]~~ Remove CEC Plugin Activation/Deactivation from CEC Control Setting [RDKEAPPRT-879,324] Jul 22, 2026

SudarsananComcast changed the title ~~Remove CEC Plugin Activation/Deactivation from CEC Control Setting [RDKEAPPRT-879,324]~~ RDKEAPPRT-879,324 - Remove CEC Plugin Activation/Deactivation from CEC Control Setting Jul 22, 2026

		const isEnabled = !!(res && res.enabled)
		console.log(`CEC initial status: ${isEnabled}`)

Uh oh!

Conversation

SudarsananComcast commented Jul 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

arun-madhavan-013 left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

SudarsananComcast commented Jul 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants